Skip to content

fix: Show skeleton when product price is validating #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

fix: Show skeleton when product price is validating #3112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 54 additions & 50 deletions packages/core/src/components/ui/ProductDetails/ProductDetailsSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { Dispatch, SetStateAction } from 'react'
import { useMemo } from 'react'

import type { ProductDetailsFragment_ProductFragment } from '@generated/graphql'
import { Skeleton as UISkeleton } from '@faststore/ui'

import { useBuyButton } from 'src/sdk/cart/useBuyButton'
import { useFormattedPrice } from 'src/sdk/product/useFormattedPrice'
Expand Down Expand Up @@ -103,57 +104,60 @@ function ProductDetailsSettings({

return (
<>
{!outOfStock && (
<section data-fs-product-details-values>
<div data-fs-product-details-values-wrapper>
<ProductPrice.Component
data-fs-product-details-prices
value={
(taxesConfiguration?.usePriceWithTaxes
? priceWithTaxes
: price) * (unitMultiplier ?? 1)
}
listPrice={
(taxesConfiguration?.usePriceWithTaxes
? listPriceWithTaxes
: listPrice) * (unitMultiplier ?? 1)
}
formatter={useFormattedPrice}
{...ProductPrice.props}
{!outOfStock &&
(isValidating ? (
<UISkeleton size={{ width: '100%', height: '50px' }} />
) : (
<section data-fs-product-details-values>
<div data-fs-product-details-values-wrapper>
<ProductPrice.Component
data-fs-product-details-prices
value={
(taxesConfiguration?.usePriceWithTaxes
? priceWithTaxes
: price) * (unitMultiplier ?? 1)
}
listPrice={
(taxesConfiguration?.usePriceWithTaxes
? listPriceWithTaxes
: listPrice) * (unitMultiplier ?? 1)
}
formatter={useFormattedPrice}
{...ProductPrice.props}
/>
{taxesConfiguration?.usePriceWithTaxes && (
<UILabel data-fs-product-details-taxes-label>
{taxesConfiguration?.taxesLabel}
</UILabel>
)}
</div>
<QuantitySelector.Component
min={1}
max={10}
unitMultiplier={useUnitMultiplier ? unitMultiplier : 1}
useUnitMultiplier={useUnitMultiplier}
{...QuantitySelector.props}
// Dynamic props shouldn't be overridable
// This decision can be reviewed later if needed
onChange={setQuantity}
// TODO: we should get the Toast values from the hCMS
onValidateBlur={(
min: number,
maxValue: number,
quantity: number
) => {
pushToast({
title: 'Invalid quantity!',
message: `The quantity you entered is outside the range of ${min} to ${maxValue}. The quantity was set to ${quantity}.`,
status: 'INFO',
icon: (
<UIIcon name="CircleWavyWarning" width={30} height={30} />
),
})
}}
/>
{taxesConfiguration?.usePriceWithTaxes && (
<UILabel data-fs-product-details-taxes-label>
{taxesConfiguration?.taxesLabel}
</UILabel>
)}
</div>
<QuantitySelector.Component
min={1}
max={10}
unitMultiplier={useUnitMultiplier ? unitMultiplier : 1}
useUnitMultiplier={useUnitMultiplier}
{...QuantitySelector.props}
// Dynamic props shouldn't be overridable
// This decision can be reviewed later if needed
onChange={setQuantity}
// TODO: we should get the Toast values from the hCMS
onValidateBlur={(
min: number,
maxValue: number,
quantity: number
) => {
pushToast({
title: 'Invalid quantity!',
message: `The quantity you entered is outside the range of ${min} to ${maxValue}. The quantity was set to ${quantity}.`,
status: 'INFO',
icon: (
<UIIcon name="CircleWavyWarning" width={30} height={30} />
),
})
}}
/>
</section>
)}
</section>
))}
{skuVariants && (
<Selectors
slugsMap={skuVariants.slugsMap}
Expand Down