-
Notifications
You must be signed in to change notification settings - Fork 75
fix: fixing preview tag style #3058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| .section [data-fs-preview-tag] { | ||
| position: fixed; | ||
| inset: 1rem 1rem auto auto; | ||
| z-index: 10000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| z-index: 10000; | |
| z-index: var(--fs-z-index-highest); |
does it work using this token? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 4a3dc98
|
@renatamottam a scenario that we can further analyze later :) |
What’s the purpose of this pull request?
This PR fixes the Preview tag styling when previews are shown in stores that use custom themes.
An example from a preview page in the
heringhomologaccount:Before
After
How it works
It replaces styles inherited from the
Badge,Tag, andIconcomponents with scoped custom styles, preventing overrides by store-specific theme customizations.How to test
heringhomologstore repository.heringhomologContent Platform, set the preview URL to your local build.faststore/corepackage from this PR into the store, orNote: The preview tag is shown only on pages previewed from the Content Platform. This change doesn't apply to the preview flow for hCMS pages.
Starters Deploy Preview
References