feat: order list placed by filter-SFS-2702 #2988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursantiago
requested review from
eduardoformiga,
hellofanny and
icaroov
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
icaroov
reviewed
Aug 11, 2025
...stOrders/MyAccountFilterSlider/MyAccountFilterFacetPlacedBy/MyAccountFilterFacetPlacedBy.tsx
Outdated
Show resolved
Hide resolved
icaroov
approved these changes
Aug 11, 2025
...stOrders/MyAccountFilterSlider/MyAccountFilterFacetPlacedBy/MyAccountFilterFacetPlacedBy.tsx
Show resolved
Hide resolved
Member
eduardoformiga
left a comment
eduardoformiga
left a comment
There was a problem hiding this comment.
Good job! I left a couple of comments, but most of them are non-blocking, just reminders for future integrations.
| import type { SelectedFacet } from 'src/sdk/search/useMyAccountFilter' | ||
|
|
||
| type Shopper = { | ||
| purchase_agent_id: string |
Member
There was a problem hiding this comment.
🎗️ It will come as userId from the shopper entity, and we'll send it as purchase_agent_id to the OMS API. We don't need to change the mock, just to remember afterward.
Comment on lines
+66
to
+69
| const selectedId = useMemo( | ||
| () => selected.find((f) => f.key === 'purchaseAgentId')?.value, | ||
| [selected] | ||
| ) |
Member
There was a problem hiding this comment.
just 1 so far, after we can select multiple.
Collaborator
Author
There was a problem hiding this comment.
Yes, i have done as in the figma for now
...stOrders/MyAccountFilterSlider/MyAccountFilterFacetPlacedBy/MyAccountFilterFacetPlacedBy.tsx
Outdated
Show resolved
Hide resolved
...stOrders/MyAccountFilterSlider/MyAccountFilterFacetPlacedBy/MyAccountFilterFacetPlacedBy.tsx
Show resolved
Hide resolved
Comment on lines
87
to
94
| const filtered = useMemo(() => { | ||
| const q = query.trim().toLowerCase() | ||
| if (!q) return mockShoppers | ||
| return mockShoppers.filter( | ||
| (s) => | ||
| s.name.toLowerCase().includes(q) || s.email.toLowerCase().includes(q) | ||
| ) | ||
| }, [query]) |
Member
There was a problem hiding this comment.
🎗️ reminder: replace this with the API call afterward.
We're deciding on how to filter shoppers already (using wildcard and firstName, lastName, but in this task let's keep the mock 😉
...stOrders/MyAccountFilterSlider/MyAccountFilterFacetPlacedBy/MyAccountFilterFacetPlacedBy.tsx
Outdated
Show resolved
Hide resolved
...stOrders/MyAccountFilterSlider/MyAccountFilterFacetPlacedBy/MyAccountFilterFacetPlacedBy.tsx
Show resolved
Hide resolved
...nt/orders/MyAccountListOrders/MyAccountFilterSlider/MyAccountFilterFacetPlacedBy/styles.scss
Show resolved
Hide resolved
|
|
||
| const placedByTag = purchaseAgentId && ( | ||
| <div key={`placed-by-${purchaseAgentId}`} data-fs-list-orders-selected-tag> | ||
| <span>Placed by: {purchaseAgentId}</span> |
Member
There was a problem hiding this comment.
🎗️ will be the name instead of purchaseAgentId in the future.
...omponents/account/orders/MyAccountListOrders/MyAccountSelectedTags/MyAccountSelectedTags.tsx
Outdated
Show resolved
Hide resolved
eduardoformiga
approved these changes
Aug 13, 2025
lariciamota
pushed a commit
that referenced
this pull request
Oct 30, 2025
## What's the purpose of this pull request? Revert changes from - #2988 since the approach to filter shopper changes to use text field instead of selected filter in the drawer. ## details remove purchaseAgentId filter and related components from `MyAccountListOrders`. This update removes the purchaseAgentId filter and its associated components from the MyAccountListOrders section. The changes include: - Deleting the MyAccountFilterFacetPlacedBy component and its styles. - Adjusting the MyAccountListOrders and MyAccountSelectedTags components to eliminate references to purchaseAgentId. - Cleaning up related styles and imports to streamline the codebase. These modifications aim to simplify the order filtering process and improve overall maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s the purpose of this pull request?
How it works?
How to test it?
Starters Deploy Preview
References
SFS-2702
Figma