-
Notifications
You must be signed in to change notification settings - Fork 75
fix: declare RatingSummary in section components #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hellofanny
merged 6 commits into
feat/reviews-and-ratings
from
feat/declare-rating-summary-in-section
Mar 11, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d7dfabc
fix: declare RatingSummary in section components
artursantiago 1c94faf
refactor: rename prop
artursantiago e1e1ef6
styles: remove comment
artursantiago d19de15
styles: remove unused import
artursantiago adf46ff
styles: remove unused import
artursantiago 8a26f35
fix: remove review modal code
artursantiago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 8 additions & 4 deletions
12
packages/core/src/components/sections/ReviewsAndRatings/DefaultComponents.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| import dynamic from 'next/dynamic' | ||
|
|
||
| const UIRatingSummary = dynamic(() => | ||
| /* webpackChunkName: "UIRatingSummary" */ | ||
| import('@faststore/ui').then((module) => module.RatingSummary) | ||
| ) | ||
|
|
||
| export const ReviewsAndRatingsDefaultComponents = { | ||
| // TODO: Update this with the components that will be used in ReviewsAndRatings section | ||
| // Olhar o packages/core/src/components/sections/ProductGallery/DefaultComponents.ts | ||
| // ou o packages/core/src/components/sections/ProductShelf/DefaultComponents.ts | ||
| // para se basear | ||
| RatingSummary: UIRatingSummary, | ||
| } as const |
11 changes: 7 additions & 4 deletions
11
packages/core/src/components/sections/ReviewsAndRatings/ReviewsAndRatings.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is because we also need to add
ReviewModalright?