Fix validate_cmd failing when file resouce is absent#77
Open
ashleygould wants to merge 5 commits intovoxpupuli:masterfrom
Open
Fix validate_cmd failing when file resouce is absent#77ashleygould wants to merge 5 commits intovoxpupuli:masterfrom
ashleygould wants to merge 5 commits intovoxpupuli:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Instead of relying on file attribute
validate_cmdI have added a secondary exec to validate the intermediate file.This added exec is triggered by the file resource and in turn triggers the
keytool importexec.This method allows for the case where the intermediate file does not yet exist.
This is a more clunky solution, but it seems to work in my environment.
I'm not sure how to write an rspec test for this.
This Pull Request (PR) fixes the following issues
Fixes #76