use stdlib::to_toml instead of toml gem #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
toml
branch
9 times, most recently
from
04e66f1 to
e997cec
Compare
traylenator
reviewed
Jun 3, 2023
manifests/aggregator.pp
Outdated
| file { "${telegraf::config_folder}/${name}.conf": | ||
| ensure => $_ensure, | ||
| content => inline_template("<%= require 'toml-rb'; TomlRB.dump({'aggregators'=>{'${plugin_type}'=>@options}}) %>"), | ||
| content => to_toml({ 'aggregators'=> { $plugin_type=> $options } }), |
There was a problem hiding this comment.
steve@arch ~> puppet apply -e '$a = to_toml({'a' => 'b'})'
Warning: This function is deprecated, please use stdlib::to_toml instead. at ["unknown", 1]:["unknown", 0]
(location: /home/steve/.puppetlabs/etc/code/modules/stdlib/lib/puppet/functions/deprecation.rb:35:in `deprecation')
Notice: Compiled catalog for arch.lan in environment production in 0.02 seconds
Notice: Applied catalog in 0.02 seconds
However you may have done on purpose to avoid the stdlib bump to v9 at this time.
Member
Author
There was a problem hiding this comment.
Indeed, because puppet/archive doesn't allow stdlib 9. We've a bit of a dependency problem on most modules that we need to sort out.
Member
Author
There was a problem hiding this comment.
I released archive and we can now depend on stdlib 9 (I hope)
traylenator
previously approved these changes
Jun 3, 2023
traylenator
left a comment
traylenator
left a comment
There was a problem hiding this comment.
LGTM with to_toml or stdlib::to_toml, as you wish.
apt deps. |
Member
Author
|
This requires puppetlabs/puppetlabs-apt#1113 |
traylenator
dismissed
their stale review
Best to again once the stars have aligned.
bastelfreak
added
backwards-incompatible
and removed
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues