Find existing quadlets more precisely#71
Closed
traylenator wants to merge 1 commit intovoxpupuli:masterfrom
Closed
Find existing quadlets more precisely#71traylenator wants to merge 1 commit intovoxpupuli:masterfrom
traylenator wants to merge 1 commit intovoxpupuli:masterfrom
Conversation
During validation of a new quadlet the existing quadlet must be copied to an ephemeral directory. This failed with: ``` cp: -r not specified; omitting directory '/etc/containers/systemd/users' ``` The extra directory should not be copied. The actually files with be `my.pod`, `my.container`, ... Particularly on Ubuntu and Debian the directory `/etc/containers/systemd/users` exists to store system provided user quadlets.
Collaborator
Author
|
This is the wrong strategy completly - I missed that. QUADLET_UNIT_DIRS can be set as multiple paths. |
Collaborator
Author
|
#72 is much better solution to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
During validation of a new quadlet the existing quadlet must be copied to an ephemeral directory.
This could fail with:
The extra directory should not be copied. The files to be copied with be of the form
my.pod,my.container, ...Particularly on Ubuntu and Debian the directory
/etc/containers/systemd/usersexists to store system provided user quadlets and that directory should be ignored.Change is:
vs