Skip to content

feat: set minimum version for openvox/puppet to 8.19.0#978

Merged
TheMeier merged 1 commit intomasterfrom
community-triage/issues/60
Aug 3, 2025
Merged

feat: set minimum version for openvox/puppet to 8.19.0#978
TheMeier merged 1 commit intomasterfrom
community-triage/issues/60

Conversation

@TheMeier
Copy link
Contributor

@TheMeier TheMeier commented Jul 26, 2025

PRs could then be create with a script like this:

#!/usr/bin/env bash
set -euo pipefail
scriptdir=$(dirname "$(readlink -f "$0")")

while read -r directory; do
  pushd "$directory"
  git switch -c update-min-openvox-version-07f8cb2
  git commit metadata.json -F "${scriptdir}/commit.txt"
  gh repo set-default "voxpupuli/$(basename "$directory")"
  git push
  gh pr create --fill --label "backwards-incompatible" --draft
  popd
done < tmp/changed_modules.txt

Ref: voxpupuli/community-triage#62

@TheMeier TheMeier requested a review from bastelfreak July 26, 2025 09:52
@TheMeier
Copy link
Contributor Author

Maybe we should use a copy that only changes the version_requirement for openvox/pupppet and nothing else, so we get clean self-contained PRs or add a command line argument to select the operation mode

@TheMeier TheMeier force-pushed the community-triage/issues/60 branch from f7d8b39 to b723827 Compare July 26, 2025 10:00
@TheMeier
Copy link
Contributor Author

Actually the labels for the resulting PRs require discussion. IMHO modulesync should not be set as that excludes it from the changelog-generator (reason)

I am also not sure wehter to set backwards-incompatible or not. IMHO it is correct, OTOH it will sooner or later require major releases for all modules.

@smortex
Copy link
Member

smortex commented Jul 30, 2025

Actually the labels for the resulting PRs require discussion. IMHO modulesync should not be set as that excludes it from the changelog-generator (reason)

Correct.

I am also not sure wehter to set backwards-incompatible or not. IMHO it is correct, OTOH it will sooner or later require major releases for all modules.

We do this when we drop support for something (os, puppet release) so I see no reason not to do that.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me feels confused (but maybe just need ☕)

@TheMeier TheMeier marked this pull request as draft August 1, 2025 08:00
TheMeier added a commit to voxpupuli/puppet-allknowingdns that referenced this pull request Aug 3, 2025
* drop support for puppet as discussed in [1]
* update openvox minimum version to 8.19.0 as discussed in [2] and [3]

[1] voxpupuli/community-triage#59
[2] voxpupuli/community-triage#60
[3] voxpupuli/modulesync_config#978 (comment)
TheMeier added a commit to voxpupuli/puppet-allknowingdns that referenced this pull request Aug 3, 2025
* drop support for puppet as discussed in [1]
* update openvox minimum version to 8.19.0 as discussed in [2] and [3]

[1] voxpupuli/community-triage#59
[2] voxpupuli/community-triage#60
[3] voxpupuli/modulesync_config#978 (comment)
@TheMeier TheMeier force-pushed the community-triage/issues/60 branch from b723827 to bf6a4c1 Compare August 3, 2025 08:51
@TheMeier TheMeier changed the title feat: set minimum version for openvox/puppet to 8.0.0 feat: set minimum version for openvox/puppet to 8.19.0 Aug 3, 2025
@TheMeier TheMeier force-pushed the community-triage/issues/60 branch from bf6a4c1 to d623989 Compare August 3, 2025 08:53
@TheMeier TheMeier marked this pull request as ready for review August 3, 2025 09:28
TheMeier added a commit to voxpupuli/puppet-alternatives that referenced this pull request Aug 3, 2025
* drop support for puppet as discussed in [1]
* update openvox minimum version to 8.19.0 as discussed in [2] and [3]

[1] voxpupuli/community-triage#59
[2] voxpupuli/community-triage#60
[3] voxpupuli/modulesync_config#978 (comment)
TheMeier added a commit to voxpupuli/puppet-amanda that referenced this pull request Aug 3, 2025
* drop support for puppet as discussed in [1]
* update openvox minimum version to 8.19.0 as discussed in [2] and [3]

[1] voxpupuli/community-triage#59
[2] voxpupuli/community-triage#60
[3] voxpupuli/modulesync_config#978 (comment)
TheMeier added a commit to voxpupuli/puppet-appd_db_agent that referenced this pull request Aug 3, 2025
* drop support for puppet as discussed in [1]
* update openvox minimum version to 8.19.0 as discussed in [2] and [3]

[1] voxpupuli/community-triage#59
[2] voxpupuli/community-triage#60
[3] voxpupuli/modulesync_config#978 (comment)
TheMeier added a commit to voxpupuli/puppet-aptly that referenced this pull request Aug 3, 2025
* drop support for puppet as discussed in [1]
* update openvox minimum version to 8.19.0 as discussed in [2] and [3]

[1] voxpupuli/community-triage#59
[2] voxpupuli/community-triage#60
[3] voxpupuli/modulesync_config#978 (comment)
@TheMeier TheMeier merged commit 27fa6d9 into master Aug 3, 2025
4 checks passed
@TheMeier TheMeier deleted the community-triage/issues/60 branch August 3, 2025 12:25
TheMeier added a commit to voxpupuli/puppet-archive that referenced this pull request Aug 3, 2025
* drop support for puppet as discussed in [1]
* update openvox minimum version to 8.19.0 as discussed in [2] and [3]

[1] voxpupuli/community-triage#59
[2] voxpupuli/community-triage#60
[3] voxpupuli/modulesync_config#978 (comment)
This was referenced Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants