Skip to content

Remove comment from devcontainer.json#1016

Merged
ekohl merged 1 commit intovoxpupuli:masterfrom
bwitt:devcontainer-json
Jan 5, 2026
Merged

Remove comment from devcontainer.json#1016
ekohl merged 1 commit intovoxpupuli:masterfrom
bwitt:devcontainer-json

Conversation

@bwitt
Copy link
Contributor

@bwitt bwitt commented Jan 2, 2026

Remove the comment from devcontainer.json so that it is valid JSON.

Fixes #1015

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was noted in the original review that vscode accepts comments like this: #976 (comment)

@bwitt
Copy link
Contributor Author

bwitt commented Jan 3, 2026

It was noted in the original review that vscode accepts comments like this: #976 (comment)

Yes vscode treats this file like a jsonc file for some reason. That does not make it valid json though.

@bwitt bwitt force-pushed the devcontainer-json branch from 5211cd7 to d3953e5 Compare January 3, 2026 18:29
@bwitt bwitt changed the title Remove comment from devcontainer.json.erb Remove comment from devcontainer.json Jan 3, 2026
@kenyon kenyon changed the title Remove comment from devcontainer.json Remove comment from devcontainer.json Jan 3, 2026
@ekohl ekohl merged commit 0258994 into voxpupuli:master Jan 5, 2026
4 checks passed
@bwitt bwitt deleted the devcontainer-json branch January 6, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated .devcontainer/devcontainer.json is not valid json

3 participants