Add TLS support to http server#332
Merged
bnfinet merged 4 commits intovouch:masterfrom Dec 8, 2020
danfaizer:feature/297_add_tls_support
Merged
Add TLS support to http server#332bnfinet merged 4 commits intovouch:masterfrom danfaizer:feature/297_add_tls_support
bnfinet merged 4 commits intovouch:masterfrom
danfaizer:feature/297_add_tls_support
Conversation
bnfinet
reviewed
Nov 17, 2020
| srv.TLSConfig = cfg.TLSConfig(cfg.Cfg.TLS.Profile) | ||
| logger.Fatal(srv.ListenAndServeTLS(cfg.Cfg.TLS.Cert, cfg.Cfg.TLS.Key)) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
althought logger.Fatal is an exit event, could you please put the following srv.ListenAndServe (non TLS) in an else block for clarity
bnfinet
reviewed
Nov 17, 2020
| # - myOrg | ||
| # - myOrg/myTeam | ||
|
|
||
| tls: |
Member
There was a problem hiding this comment.
Please include the the env var names in the documentation
Contributor
Author
|
Including coverage: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides native TLS support. Related issue: #297
In order to enable TLS you must configure: