[misc] fix: Allow HF model ID with use_shm
#3663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to allow using Hugging Face model IDs with use_shm. The implementation correctly adds logic to download models from the Hub. However, I've found a critical issue where this logic is incorrectly tied to the use_shm flag, causing it to fail when use_shm is false. Additionally, the error handling is too broad and silences all exceptions, which will make debugging difficult. I've provided suggestions to fix these issues.
|
ci unrelated |
wuxibin89
reviewed
Oct 9, 2025
| # Save to a local path for persistence. | ||
| local_path = copy_local_path_from_hdfs(src, cache_dir, filelock, verbose, always_recopy) | ||
|
|
||
| if use_shm and isinstance(local_path, str) and not os.path.exists(local_path): |
There was a problem hiding this comment.
Why only download model when use_shm=True?
There was a problem hiding this comment.
Didn't want to cause issues with other paths using the method, if you want I can have all calls
wuxibin89
approved these changes
Oct 10, 2025
masoudhashemi
pushed a commit
to masoudhashemi/verl
that referenced
this pull request
Oct 19, 2025
techkang
pushed a commit
to techkang/verl
that referenced
this pull request
Oct 31, 2025
mtian8
pushed a commit
to mtian8/verl
that referenced
this pull request
Nov 1, 2025
wangboxiong320
pushed a commit
to wangboxiong320/verl
that referenced
this pull request
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.