Skip to content

[megatron, training_utils] fix: encoder pp is removed in mcore >= 0.14 #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

[megatron, training_utils] fix: encoder pp is removed in mcore >= 0.14 #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion verl/utils/megatron_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,9 @@ def get_transformer_layer_offset(pipeline_rank, vp_stage, config: TransformerCon
inspect.signature(parallel_state.is_pipeline_first_stage).parameters.get("vp_stage", None) is not None
)
extra_kwargs = {} if not has_vp_stage else {"ignore_virtual": False, "vp_stage": vp_stage}
if not parallel_state.is_inside_encoder():
# is_inside_encoder is deprecated and removed in mcore v0.14.0
# https://github.com/NVIDIA/Megatron-LM/commit/b600e38d7b2a5b31d8d90e35bcf0cad18977a99c
if hasattr(parallel_state, "is_inside_encoder") and not parallel_state.is_inside_encoder():
pp_decoder_start = parallel_state.get_pipeline_model_parallel_decoder_start()
if pp_decoder_start is not None:
pipeline_rank = pipeline_rank - pp_decoder_start
Expand Down