Skip to content

Conversation

@vermouth1992
Copy link
Collaborator

What does this PR do?

  • Support parameter generator for model engine
  • Add tests for Qwen3 and Qwen3MoE

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a parameter generator for model engines and adds corresponding tests. The implementation for FSDP and Megatron engines has been added. My review focuses on correctness and consistency in these new engine implementations.

I've identified a critical issue in the FSDP engine implementation where state_dict() is called without the necessary context, which could lead to incorrect behavior with sharded models. Additionally, there's a high-severity issue in the Megatron engine implementation regarding inconsistent parameter offloading logic compared to the FSDP engine, which could cause GPU memory issues. The refactoring in the actor and critic roles looks good.

@vermouth1992 vermouth1992 merged commit d33c85e into volcengine:main Sep 19, 2025
66 of 74 checks passed
masoudhashemi pushed a commit to masoudhashemi/verl that referenced this pull request Oct 19, 2025
mtian8 pushed a commit to mtian8/verl that referenced this pull request Nov 1, 2025
wangboxiong320 pushed a commit to wangboxiong320/verl that referenced this pull request Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants