Skip to content

Conversation

@yyDing1
Copy link
Collaborator

@yyDing1 yyDing1 commented Sep 9, 2025

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

polishing the code of refactored reward model

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the reward model code, introducing a base class and a registry for different implementations, which is a solid architectural improvement for extensibility. The file structure has also been reorganized for better clarity. My review focuses on two main areas of concern: the removal of important documentation from a configuration class, and the use of a monkey patch for a third-party library, which could introduce brittleness. Addressing these points will help ensure the long-term maintainability of the code.

@yyDing1 yyDing1 changed the title [worker] refactor: polishing the code of refactored reward model [worker] refactor: move the implementation of rm to workers.roles and polish Sep 9, 2025
@vermouth1992 vermouth1992 merged commit b5a5e88 into volcengine:main Sep 9, 2025
56 of 57 checks passed
@yyDing1 yyDing1 deleted the refactor-genrm branch September 10, 2025 03:26
pimang62 pushed a commit to KU-AGI/verl that referenced this pull request Sep 12, 2025
WncFht pushed a commit to WncFht/verl that referenced this pull request Oct 10, 2025
masoudhashemi pushed a commit to masoudhashemi/verl that referenced this pull request Oct 19, 2025
techkang pushed a commit to techkang/verl that referenced this pull request Oct 31, 2025
mtian8 pushed a commit to mtian8/verl that referenced this pull request Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants