Skip to content

Conversation

@Roseisrosie
Copy link
Contributor

@Roseisrosie Roseisrosie commented Sep 5, 2025

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Since the current vllm-ascend does not yet support sleep level = 2 - causing rewards to always be -1 - please set sleep level to 1 when using the NPU.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fix to set VLLM_SLEEP_LEVEL to 1 when running on Ascend NPU devices. This is achieved by adding a check for NPU availability before potentially setting the sleep level to 2. The change is localized to the vLLM initialization logic and correctly uses a utility function to detect NPU presence. The implementation appears correct and effectively addresses the issue described in the pull request title.

elif vs.parse(package_version) >= vs.parse("0.7.0"):
vllm_version = package_version
if vs.parse(package_version) >= vs.parse("0.8.5"):
if vs.parse(package_version) >= vs.parse("0.8.5") and not is_npu_available:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest writting like this:

if package_version is None:
    xxx
elif is_npu_available:
    VLLM_SLEEP_MODEL = 1 # sleep_mode=2 is not supported on vllm-ascend for now, will remove this restriction when this ability is ready.

@addsubmuldiv addsubmuldiv force-pushed the main branch 2 times, most recently from 1e4af49 to 4631b57 Compare September 5, 2025 09:45
@vermouth1992 vermouth1992 merged commit eada037 into volcengine:main Sep 9, 2025
54 of 57 checks passed
pimang62 pushed a commit to KU-AGI/verl that referenced this pull request Sep 12, 2025
WncFht pushed a commit to WncFht/verl that referenced this pull request Oct 10, 2025
masoudhashemi pushed a commit to masoudhashemi/verl that referenced this pull request Oct 19, 2025
techkang pushed a commit to techkang/verl that referenced this pull request Oct 31, 2025
mtian8 pushed a commit to mtian8/verl that referenced this pull request Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants