Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ async def generate(
request_id: str,
image_data: Optional[list[Any]] = None,
) -> TokenOutput:
sampling_params.setdefault("repetition_penalty", self.config.rollout.get("repetition_penalty", 1.0))
return await self.master_worker.generate.remote(prompt_ids, sampling_params, request_id, image_data=image_data)

async def wake_up(self):
Expand Down
2 changes: 1 addition & 1 deletion verl/workers/rollout/sglang_rollout/sglang_rollout.py
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ def _init_sampling_params(self, **kwargs):
max_new_tokens=self.config.response_length,
presence_penalty=0.0,
frequency_penalty=0.0,
repetition_penalty=1.0,
repetition_penalty=self.config.get("repetition_penalty", 1.0),
)
# supporting adding any sampling params from the config file
for k in self.config.keys():
Expand Down
1 change: 1 addition & 0 deletions verl/workers/rollout/vllm_rollout/vllm_async_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ async def generate(
) -> TokenOutput:
max_tokens = self.max_model_len - len(prompt_ids)
sampling_params["logprobs"] = 0 if sampling_params.pop("logprobs", False) else None
sampling_params.setdefault("repetition_penalty", self.config.rollout.get("repetition_penalty", 1.0))
sampling_params = SamplingParams(max_tokens=max_tokens, **sampling_params)
prompt_ids = _qwen2_5_vl_dedup_image_tokens(prompt_ids, self.processor)
prompt = TokensPrompt(
Expand Down
1 change: 1 addition & 0 deletions verl/workers/rollout/vllm_rollout/vllm_rollout_spmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ def __init__(
n=1,
logprobs=0, # can be set to 0 and let actor to recompute
max_tokens=config.response_length,
repetition_penalty=config.get("repetition_penalty", 1.0),
)

kwargs["detokenize"] = False
Expand Down
Loading