Skip to content

Conversation

@looput
Copy link
Contributor

@looput looput commented Aug 25, 2025

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

API and Usage Example

When using xargs to perform SFT training on multiple datasets, the command is:

torchrun --nnodes=1 --nproc_per_node=8 -m verl.trainer.fsdp_sft_trainer \
    data.train_files=["data_path_1","data_path_2"] \
    ...

The existing code checks whether the input is a list, but the actual parsed result is a ListConfig, causing an extra level of nesting and leading to an error.

        if not isinstance(parquet_files, list):
            parquet_files = [parquet_files]

Therefore, the condition is updated to isinstance(parquet_files, list | ListConfig).

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a type-checking issue in MultiTurnSFTDataset by updating the condition to correctly handle omegaconf.ListConfig inputs for parquet_files. This prevents incorrect list nesting and ensures that multiple file paths provided via configuration are processed correctly. The change is a good improvement. I've added one high-severity comment regarding an unhandled edge case that could lead to a crash.

@vermouth1992 vermouth1992 merged commit 40bf962 into volcengine:main Aug 25, 2025
46 of 49 checks passed
PopSoda2002 pushed a commit to PopSoda2002/verl that referenced this pull request Aug 26, 2025
yellowbee686 pushed a commit to yellowbee686/verl that referenced this pull request Aug 27, 2025
cczitong123 pushed a commit to cczitong123/verl that referenced this pull request Sep 5, 2025
DDVD233 pushed a commit to DDVD233/mirl that referenced this pull request Sep 5, 2025
WncFht pushed a commit to WncFht/verl that referenced this pull request Oct 10, 2025
techkang pushed a commit to techkang/verl that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants