[rollout,vllm] feat: unify vllm and sglang method to async #2982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuxibin89
requested review from
PeterSH6,
SwordFaith,
chenhaiq and
zhaochenyang20
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the vLLM rollout worker to use asyncio, unifying its interface with the SGLang worker. The changes correctly replace threading with asyncio tasks and use zmq.asyncio. However, the implementation has a critical flaw where synchronous, long-running operations are called directly within async methods, which will block the event loop and negate the benefits of asynchronicity. I've provided suggestions to run these blocking calls in a thread pool executor to make the implementation truly non-blocking.
|
Shall we follow Gemini's suggestion? |
No, these |
vermouth1992
approved these changes
Aug 11, 2025
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Aug 11, 2025
…e#2982) ### What does this PR do? Change vLLM method to async to unify with SGLang.
ChangyiYang
pushed a commit
to SwordFaith/verl
that referenced
this pull request
Aug 16, 2025
…e#2982) ### What does this PR do? Change vLLM method to async to unify with SGLang.
whatadayG
pushed a commit
to whatadayG/verl
that referenced
this pull request
Sep 5, 2025
…e#2982) ### What does this PR do? Change vLLM method to async to unify with SGLang.
WncFht
pushed a commit
to WncFht/verl
that referenced
this pull request
Oct 10, 2025
…e#2982) ### What does this PR do? Change vLLM method to async to unify with SGLang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change vLLM method to async to unify with SGLang.