Skip to content

[fsdp, trainer] fix: save config parameters to wandb in SFT #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

[fsdp, trainer] fix: save config parameters to wandb in SFT #2884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f958b
Save Config parameters to wandb in SFT
EasonZhong668 Aug 3, 2025
7ad2ff9
move import to the top of the file
EasonZhong668 Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion verl/trainer/fsdp_sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import hydra
import torch
import torch.distributed
from omegaconf import DictConfig
from omegaconf import DictConfig, OmegaConf
from peft import LoraConfig, TaskType, get_peft_model
from tensordict import TensorDict
from torch import nn, optim
Expand Down Expand Up @@ -688,6 +688,7 @@ def fit(self):
project_name=self.config.trainer.project_name,
experiment_name=self.config.trainer.experiment_name,
default_backend=self.config.trainer.logger,
config=OmegaConf.to_container(self.config, resolve=True),
)

global_step = self.resume_global_step # Start from resumed step
Expand Down