Skip to content

Conversation

@leo-pony
Copy link
Contributor

@leo-pony leo-pony commented Jul 28, 2025

What does this PR do?

Handle the use case of verl + vllm + vllm-ascend(v0.9.1), detail information see #2564
vllm-ascend v0.9.1 is the next upcoming commercial release branch, with the previous commercial release branch is vllm-ascend v0.7.3.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

Test on ascend npu: GRPO, FSDP backend, Qwen2.5-0.5B mode.

API and Usage Example

No changes

Design & Code Changes

vllm+vllm-ascend(v0.9.1) normal use case:

In vllm 0.7.3 uses pytorch2.5.1, and the type hint for infer_schema of mode is List[int]. vllm 0.9.1 uses pytorch 2.7, and to keep consistence with pytorch2.7, and vllm changed hint type to list[int] to infer_schema of mode. Type hint List[int] and list[int] is not compatible.
image
vllm-ascend version 0.9.1 needs to be used in conjunction with vllm 0.9.1. But vllm-ascend 0.9.1 max supportted pytorch version is 2.5.1. As pytorch 2.5.1 using List[int] as type hint, vllm-ascend needs add patch to infer_schema of mode to successfully running in pytorch 2.5.1 environment. The patch workflow as following graph display.
As vllm hardware limits, vllm-ascend currently patch type hint list[int] during vllm LLM instance creating process. This is okay for most vllm-ascend applications.

vllm+vllm-ascend(v0.9.1) currently workflow in verl:

For verl+vllm-ascend+pytorch2.5.1 there has a problem, as following:
verl currently import vllm modes before create vllm LLM instance operation. So error take place: pass list[int] to infer_schema which needs List[int], and then running failed.
image

workflow in this PR in verl to handle hint type mismatch issue:

Actully patch_vllm_moe_model_weight_loader is after the operation of LLM create. "import vllm modes" action just been prematurely executed during _build_rollout processing, just file becasue vllm_utils.py in which there has another functions that needs by _build_rollout, by the way those functions been imported, vllm mode been imported. Lets vllm-hardware plugins makes it's patchs take effect, then this problem fixed: move patch_vllm_moe_model_weight_loader funciton to independent file, and import patch_vllm_moe_model_weight_loader just before wight loader patching operation.
image

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the vLLM patching logic to resolve a type hint incompatibility issue when using verl with vllm-ascend. By moving the patch_vllm_moe_model_weight_loader function to a new vllm_patch.py module and deferring its import until it's needed, the change ensures that hardware-specific patches from vllm-ascend are applied before any vLLM models are imported by verl, which fixes the runtime error. The overall approach is sound. I've identified a critical issue in the new vllm_patch.py module that could lead to runtime errors and have provided a detailed comment with a suggested fix.

@FightingZhen
Copy link
Collaborator

LGTM!

@leo-pony leo-pony changed the title [vllm] Fix verl + vllm-ascend(version 0.9.1) running failed issue [vllm] fix: verl + vllm-ascend(version 0.9.1) running failed issue Jul 29, 2025
@leo-pony
Copy link
Contributor Author

leo-pony commented Jul 29, 2025

@vermouth1992
I'd like to ask for help. The code in this pull request doesn't appear to modify the GPU logic, but I'm confused as to why three GPU-related test cases in CI are failing.
Additional information: The three test cases of yesterday's PR code passed. The difference between today's code and last night's is that vllm_utils.py and vllm_patch.py were moved to the newly created vllm directory.
Do you have any idea?

@vermouth1992 vermouth1992 merged commit bf89f61 into volcengine:main Jul 30, 2025
58 of 66 checks passed
yellowbee686 pushed a commit to yellowbee686/verl that referenced this pull request Jul 31, 2025
…olcengine#2782)

### What does this PR do?

> Handle the use case of verl + vllm + vllm-ascend(v0.9.1), detail
information see volcengine#2564
vllm-ascend v0.9.1 is the next upcoming commercial release branch, with
the previous commercial release branch is vllm-ascend v0.7.3.

### Checklist Before Starting

- [ ] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> Test on ascend npu: GRPO, FSDP backend, Qwen2.5-0.5B mode.

### API and Usage Example

> No changes

### Design & Code Changes

#### vllm+vllm-ascend(v0.9.1) normal use case:
In vllm 0.7.3 uses pytorch2.5.1, and the type hint for infer_schema of
mode is List[int]. vllm 0.9.1 uses pytorch 2.7, and to keep consistence
with pytorch2.7, and vllm changed hint type to list[int] to infer_schema
of mode. Type hint List[int] and list[int] is not compatible.
<img width="754" height="434" alt="image"
src="https://github.com/user-attachments/assets/40a40e4f-6092-4d89-baff-95c88437a13b"
/>
vllm-ascend version 0.9.1 needs to be used in conjunction with vllm
0.9.1. But vllm-ascend 0.9.1 max supportted pytorch version is 2.5.1. As
pytorch 2.5.1 using List[int] as type hint, vllm-ascend needs add patch
to infer_schema of mode to successfully running in pytorch 2.5.1
environment. The patch workflow as following graph display.
As vllm hardware limits, vllm-ascend currently patch type hint list[int]
during vllm LLM instance creating process. This is okay for most
vllm-ascend applications.

#### vllm+vllm-ascend(v0.9.1) currently workflow in verl:
For verl+vllm-ascend+pytorch2.5.1 there has a problem, as following:
verl currently import vllm modes before create vllm LLM instance
operation. So error take place: pass list[int] to infer_schema which
needs List[int], and then running failed.
<img width="954" height="660" alt="image"
src="https://github.com/user-attachments/assets/844631b5-1d60-4412-9feb-4324d80d415d"
/>

#### workflow in this PR in verl to handle hint type mismatch issue:
Actully patch_vllm_moe_model_weight_loader is after the operation of LLM
create. "import vllm modes" action just been prematurely executed during
_build_rollout processing, just file becasue vllm_utils.py in which
there has another functions that needs by _build_rollout, by the way
those functions been imported, vllm mode been imported. Lets
vllm-hardware plugins makes it's patchs take effect, then this problem
fixed: move patch_vllm_moe_model_weight_loader funciton to independent
file, and import patch_vllm_moe_model_weight_loader just before wight
loader patching operation.

![image](https://github.com/user-attachments/assets/70a7527e-2671-4435-9d96-ca8595b534c7)


### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [ ] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [ ] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)

---------

Signed-off-by: leo-pony <[email protected]>
Juniper1021 pushed a commit to Juniper1021/verl that referenced this pull request Aug 7, 2025
…olcengine#2782)

### What does this PR do?

> Handle the use case of verl + vllm + vllm-ascend(v0.9.1), detail
information see volcengine#2564
vllm-ascend v0.9.1 is the next upcoming commercial release branch, with
the previous commercial release branch is vllm-ascend v0.7.3.

### Checklist Before Starting

- [ ] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> Test on ascend npu: GRPO, FSDP backend, Qwen2.5-0.5B mode.

### API and Usage Example

> No changes

### Design & Code Changes

#### vllm+vllm-ascend(v0.9.1) normal use case:
In vllm 0.7.3 uses pytorch2.5.1, and the type hint for infer_schema of
mode is List[int]. vllm 0.9.1 uses pytorch 2.7, and to keep consistence
with pytorch2.7, and vllm changed hint type to list[int] to infer_schema
of mode. Type hint List[int] and list[int] is not compatible.
<img width="754" height="434" alt="image"
src="https://github.com/user-attachments/assets/40a40e4f-6092-4d89-baff-95c88437a13b"
/>
vllm-ascend version 0.9.1 needs to be used in conjunction with vllm
0.9.1. But vllm-ascend 0.9.1 max supportted pytorch version is 2.5.1. As
pytorch 2.5.1 using List[int] as type hint, vllm-ascend needs add patch
to infer_schema of mode to successfully running in pytorch 2.5.1
environment. The patch workflow as following graph display.
As vllm hardware limits, vllm-ascend currently patch type hint list[int]
during vllm LLM instance creating process. This is okay for most
vllm-ascend applications.

#### vllm+vllm-ascend(v0.9.1) currently workflow in verl:
For verl+vllm-ascend+pytorch2.5.1 there has a problem, as following:
verl currently import vllm modes before create vllm LLM instance
operation. So error take place: pass list[int] to infer_schema which
needs List[int], and then running failed.
<img width="954" height="660" alt="image"
src="https://github.com/user-attachments/assets/844631b5-1d60-4412-9feb-4324d80d415d"
/>

#### workflow in this PR in verl to handle hint type mismatch issue:
Actully patch_vllm_moe_model_weight_loader is after the operation of LLM
create. "import vllm modes" action just been prematurely executed during
_build_rollout processing, just file becasue vllm_utils.py in which
there has another functions that needs by _build_rollout, by the way
those functions been imported, vllm mode been imported. Lets
vllm-hardware plugins makes it's patchs take effect, then this problem
fixed: move patch_vllm_moe_model_weight_loader funciton to independent
file, and import patch_vllm_moe_model_weight_loader just before wight
loader patching operation.

![image](https://github.com/user-attachments/assets/70a7527e-2671-4435-9d96-ca8595b534c7)


### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [ ] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [ ] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)

---------

Signed-off-by: leo-pony <[email protected]>
vermouth1992 pushed a commit that referenced this pull request Sep 5, 2025
…3345)

### What does this PR do?

After
[pr#3285](19020f6),
[issue 2564](#2564) began to
reappear. Following the modification of
[pr#2782](#2782), [issue
2564](#2564) was solved.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here:
[pr#2782](#2782)
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
whatadayG pushed a commit to whatadayG/verl that referenced this pull request Sep 5, 2025
…olcengine#2782)

### What does this PR do?

> Handle the use case of verl + vllm + vllm-ascend(v0.9.1), detail
information see volcengine#2564
vllm-ascend v0.9.1 is the next upcoming commercial release branch, with
the previous commercial release branch is vllm-ascend v0.7.3.

### Checklist Before Starting

- [ ] Search for similar PRs. Paste at least one query link here: ...
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> Test on ascend npu: GRPO, FSDP backend, Qwen2.5-0.5B mode.

### API and Usage Example

> No changes

### Design & Code Changes

#### vllm+vllm-ascend(v0.9.1) normal use case:
In vllm 0.7.3 uses pytorch2.5.1, and the type hint for infer_schema of
mode is List[int]. vllm 0.9.1 uses pytorch 2.7, and to keep consistence
with pytorch2.7, and vllm changed hint type to list[int] to infer_schema
of mode. Type hint List[int] and list[int] is not compatible.
<img width="754" height="434" alt="image"
src="https://github.com/user-attachments/assets/40a40e4f-6092-4d89-baff-95c88437a13b"
/>
vllm-ascend version 0.9.1 needs to be used in conjunction with vllm
0.9.1. But vllm-ascend 0.9.1 max supportted pytorch version is 2.5.1. As
pytorch 2.5.1 using List[int] as type hint, vllm-ascend needs add patch
to infer_schema of mode to successfully running in pytorch 2.5.1
environment. The patch workflow as following graph display.
As vllm hardware limits, vllm-ascend currently patch type hint list[int]
during vllm LLM instance creating process. This is okay for most
vllm-ascend applications.

#### vllm+vllm-ascend(v0.9.1) currently workflow in verl:
For verl+vllm-ascend+pytorch2.5.1 there has a problem, as following:
verl currently import vllm modes before create vllm LLM instance
operation. So error take place: pass list[int] to infer_schema which
needs List[int], and then running failed.
<img width="954" height="660" alt="image"
src="https://github.com/user-attachments/assets/844631b5-1d60-4412-9feb-4324d80d415d"
/>

#### workflow in this PR in verl to handle hint type mismatch issue:
Actully patch_vllm_moe_model_weight_loader is after the operation of LLM
create. "import vllm modes" action just been prematurely executed during
_build_rollout processing, just file becasue vllm_utils.py in which
there has another functions that needs by _build_rollout, by the way
those functions been imported, vllm mode been imported. Lets
vllm-hardware plugins makes it's patchs take effect, then this problem
fixed: move patch_vllm_moe_model_weight_loader funciton to independent
file, and import patch_vllm_moe_model_weight_loader just before wight
loader patching operation.

![image](https://github.com/user-attachments/assets/70a7527e-2671-4435-9d96-ca8595b534c7)


### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [ ] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [ ] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)

---------

Signed-off-by: leo-pony <[email protected]>
cczitong123 pushed a commit to cczitong123/verl that referenced this pull request Sep 5, 2025
…olcengine#3345)

### What does this PR do?

After
[pr#3285](volcengine@19020f6),
[issue 2564](volcengine#2564) began to
reappear. Following the modification of
[pr#2782](volcengine#2782), [issue
2564](volcengine#2564) was solved.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here:
[pr#2782](volcengine#2782)
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
yellowbee686 pushed a commit to yellowbee686/verl that referenced this pull request Sep 5, 2025
…olcengine#3345)

### What does this PR do?

After
[pr#3285](volcengine@19020f6),
[issue 2564](volcengine#2564) began to
reappear. Following the modification of
[pr#2782](volcengine#2782), [issue
2564](volcengine#2564) was solved.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here:
[pr#2782](volcengine#2782)
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
VocabVictor pushed a commit to VocabVictor/verl-plus that referenced this pull request Sep 24, 2025
…3345)

### What does this PR do?

After
[pr#3285](volcengine/verl@4a2d266),
[issue 2564](volcengine/verl#2564) began to
reappear. Following the modification of
[pr#2782](volcengine/verl#2782), [issue
2564](volcengine/verl#2564) was solved.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here:
[pr#2782](volcengine/verl#2782)
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
masoudhashemi pushed a commit to masoudhashemi/verl that referenced this pull request Oct 19, 2025
…olcengine#3345)

### What does this PR do?

After
[pr#3285](volcengine@19020f6),
[issue 2564](volcengine#2564) began to
reappear. Following the modification of
[pr#2782](volcengine#2782), [issue
2564](volcengine#2564) was solved.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here:
[pr#2782](volcengine#2782)
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
techkang pushed a commit to techkang/verl that referenced this pull request Oct 31, 2025
…olcengine#3345)

### What does this PR do?

After
[pr#3285](volcengine@19020f6),
[issue 2564](volcengine#2564) began to
reappear. Following the modification of
[pr#2782](volcengine#2782), [issue
2564](volcengine#2564) was solved.

### Checklist Before Starting

- [x] Search for similar PRs. Paste at least one query link here:
[pr#2782](volcengine#2782)
- [x] Format the PR title as `[{modules}] {type}: {description}` (This
will be checked by the CI)
- `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`,
`trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`,
`ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`,
`env`, `tool`, `ckpt`, `doc`, `data`
- If this PR involves multiple modules, separate them with `,` like
`[megatron, fsdp, doc]`
  - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test`
- If this PR breaks any API (CLI arguments, config, function signature,
etc.), add `[BREAKING]` to the beginning of the title.
  - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching`

### Test

> For changes that can not be tested by CI (e.g., algorithm
implementation, new model support), validate by experiment(s) and show
results like training curve plots, evaluation results, etc.

### API and Usage Example

> Demonstrate how the API changes if any, and provide usage example(s)
if possible.

```python
# Add code snippet or script demonstrating how to use this
```

### Design & Code Changes

> Demonstrate the high-level design if this PR is complex, and list the
specific changes.

### Checklist Before Submitting

> [!IMPORTANT]
> Please check all the following items before requesting a review,
otherwise the reviewer might deprioritize this PR for review.

- [x] Read the [Contribute
Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md).
- [x] Apply [pre-commit
checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting):
`pre-commit install && pre-commit run --all-files --show-diff-on-failure
--color=always`
- [ ] Add / Update [the
documentation](https://github.com/volcengine/verl/tree/main/docs).
- [ ] Add unit or end-to-end test(s) to [the CI
workflow](https://github.com/volcengine/verl/tree/main/.github/workflows)
to cover all the code. If not feasible, explain why: ...
- [ ] Once your PR is ready for CI, send a message in [the `ci-request`
channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the
`verl` Slack
workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
(If not accessible, please try [the Feishu group
(飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants