-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[rollout] fix: fix tool_agent_loop gsm8k task not use ground_truth in dataset #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
20f3251
[fix] agent_loop: fix tool_agent_loop gsm8k task not use ground_truth…
vllbc 3202fb0
fix some bugs
vllbc 2e3432b
Do not modify any parameters of the gsm8k tool
vllbc ef90aec
rename tool_kwargs to tool_kwargs_batch and use ruff format
vllbc 82a9542
add kwargs to avoid break all subclasses of AgentLoopBase
vllbc 8a6d421
Merge branch 'main' into fix_tool_agent_loop
vllbc 632caae
remove some blank after fix conflict
vllbc 21892ad
using pre-commit to format code
vllbc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break all subclasses of AgentLoopBase, we should make
tools_kwargsan optional argument.https://github.com/volcengine/verl/blob/main/verl/experimental/agent_loop/agent_loop.py#L171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I should add
**kwargsto therunmethod of theAgentLoopBaseclass?