[rollout] feat: remove chat scheduler #2725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuxibin89
requested review from
PeterSH6,
eric-haibin-lin,
tongyx361 and
vermouth1992
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the ChatCompletionScheduler and its related components. The changes are mostly subtractive and align with the goal of removing this feature, likely in favor of native tool support in inference engines or a new agent loop implementation.
My review has identified one high-severity issue: a test file for a function that is still in use has been removed, which impacts test coverage and future maintainability. Please see the specific comment for details.
Collaborator
|
LGTM |
Collaborator
Collaborator
|
Could we bump to 0.4.9+ at once? |
wuxibin89
force-pushed
the
wuxibin/remove_chatscheduler
branch
from
b4006a1 to
566b703
Compare
vermouth1992
approved these changes
Jul 25, 2025
oseyosey
pushed a commit
to oseyosey/verl
that referenced
this pull request
Jul 28, 2025
### What does this PR do? Remove chat scheduler as describe in volcengine#2618
CurryRice233
added a commit
to CurryRice233/verl
that referenced
this pull request
Jul 28, 2025
* origin/mindspeed: (39 commits) [perf] feat: add optional role selection in discrete mode for NPU Profiler (volcengine#2750) [rollout] feat: remove chat scheduler (volcengine#2725) [trainer] refactor: Make sure to keep the type checking (volcengine#2634) [doc] style: change resize handle from gradient to plain color (volcengine#2746) [CI] feat: add `mypy` to pre-commit (volcengine#2614) [megatron] feat: a bunch of optimzation on vram, sequence packing (volcengine#2678) [docker] feat: upgrade to torch 2.7, sglang 0.4.8 (volcengine#2617) [doc] feat: add resizable sidebar and improve layout (volcengine#2577) [ci] fix: release ascend test time, fix one step off-policy CI (volcengine#2731) [recipe] chore: add retool training script (volcengine#2732) [ci] fix: checkpoint_convertor ci miss a hf model download (volcengine#2730) [doc] feat: Add agent-lightning in the list of "awesome works using verl (volcengine#2726) [tool] fix: geo3k create return str instead of tuple (volcengine#2714) [megatron] fix: resolve backward propagation error in megatron_actor due to shared logits tensor in-place modification (volcengine#2484) [misc] chore: bump main branch version to v0.5.0.dev (volcengine#2718) [sglang] fix: Adding strict naming sanity for sglang (volcengine#2719) [ray] feat: RayWorkerGroup support set worker env (volcengine#2685) [ci] test: add CriticWorker unit test, make some util CPU friendly (volcengine#2717) [cfg] refactor: add ActorConfig, EngineConfig, and ActorWorker unit test, refactor validation code (volcengine#2621) [misc] chore: bump version to v0.5.0 (volcengine#2716) ...
7 tasks
SumanthRH
pushed a commit
to SumanthRH/verl
that referenced
this pull request
Jul 29, 2025
### What does this PR do? Remove chat scheduler as describe in volcengine#2618
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jul 31, 2025
### What does this PR do? Remove chat scheduler as describe in volcengine#2618
Juniper1021
pushed a commit
to Juniper1021/verl
that referenced
this pull request
Aug 7, 2025
### What does this PR do? Remove chat scheduler as describe in volcengine#2618
whatadayG
pushed a commit
to whatadayG/verl
that referenced
this pull request
Sep 5, 2025
### What does this PR do? Remove chat scheduler as describe in volcengine#2618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove chat scheduler as describe in #2618