Skip to content

Conversation

@JesseStutler
Copy link
Member

What type of PR is this?

Similar to #4521

What this PR does / why we need it:

We need to automatically bump version for release branch, currently all the TAGs in release branch are hard-coded

Which issue(s) this PR fixes:

Cherry-pick from #4372

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JesseStutler
Copy link
Member Author

/cc @Monokaix

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 11, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @JesseStutler, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've cherry-picked changes to enhance our release automation by introducing a dedicated script for bumping versions and streamlining our build process. This aims to make future version releases more automated and less prone to manual errors, particularly for release branches where tags were previously hard-coded. The changes also include improvements to our YAML consistency checks to ensure generated files are always up-to-date and accurate.

Highlights

  • Automated Version Bumping Script: I've introduced a new shell script, hack/bump-version.sh, which fully automates the process of updating version numbers across various project files, including the new .release-version file, Helm charts, and go.mod dependencies. This script also handles regenerating development YAMLs, committing changes, and creating a pull request, significantly streamlining our release workflow.
  • Dynamic Makefile Configuration: The Makefile and Makefile.def have been refactored to remove hardcoded version tags. This change makes our build and YAML generation processes more dynamic and flexible, allowing them to be driven by the new automation script rather than requiring manual updates for each release.
  • Enhanced YAML Consistency Checks: The hack/check-generated-yaml.sh script has been substantially improved. It now includes intelligent logic to compare generated YAML files against their development counterparts, correctly handling different tagging conventions (such as 'latest' versus specific release tags) and ensuring overall consistency of our generated artifacts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a script to automate version bumping and updates various files to remove hardcoded versions, which is a significant improvement for release management. The new bump-version.sh script is comprehensive, handling file updates, git operations, and PR creation. The check-generated-yaml.sh script is also improved to be more dynamic. I have a few suggestions to make the scripts even more robust and maintainable.

@JesseStutler JesseStutler force-pushed the bump-version-auto-release-1.11 branch from afbbc00 to 36be382 Compare August 13, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants