Automated cherry pick of #4473: fix node count reconcile

[Monokaix]

Cherry pick of #4473 on release-1.12.

#4473: fix node count reconcile
For details on the cherry pick process, see the cherry picks page.

[gemini-code-assist]

Summary of Changes

Hello @Monokaix, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, an automated cherry-pick from #4473, addresses a critical issue in the HyperNode controller where the reported node count was inaccurate. The changes introduce a more robust mechanism to calculate the actual number of nodes associated with a HyperNode by dynamically evaluating its member selectors against the cluster's live node information, ensuring the status accurately reflects the topology.

Highlights

• HyperNode Node Count Correction: I've updated the core logic for reconciling HyperNode status to accurately determine the actual number of nodes that match the HyperNode's member selectors, rather than simply counting the defined members. This addresses an inaccuracy in the previously reported node counts.
• Node Listing Permissions: I've added the necessary RBAC permissions to the controller's ClusterRole, allowing it to list and watch Kubernetes nodes. This is crucial for the controller to gather the real-time node information needed for accurate reconciliation.
• New Node Counting Utility: I've introduced a new internal utility function, actualNodeCnt, within the HyperNode controller. This function performs the accurate node calculation by leveraging the Kubernetes node lister and evaluating various member selector types (exact, regex, label).
• Refactored Member Selection Logic: The getMembers utility function in the scheduler API has been promoted to a public GetMembers function. Its internal logic was also refined to handle different member selector types more effectively, ensuring consistent and correct node resolution.
• Enhanced Test Coverage: I've significantly expanded the unit tests for HyperNode status synchronization. New test cases now cover scenarios involving various node member selection strategies, ensuring the new node counting logic functions as expected under diverse configurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[JesseStutler]

/lgtm

[gemini-code-assist]

Code Review

This pull request cherry-picks a fix for node count reconciliation in hypernode. The change correctly calculates the number of nodes by resolving member selectors, which is a significant improvement in correctness. The supporting changes, including RBAC updates and controller modifications, are appropriate. I've identified a high-severity issue in the refactored GetMembers helper function where error handling could lead to incorrect results, and have provided suggestions to fix it.

[lowang-bh]

/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lowang-bh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment