Skip to content

Conversation

@Monokaix
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

In version before v1.12, queue update use applustatus of SSA and controller manage both queue.status.state and queue.status.allocated, and scheduler will also update queue.status.allocated, so there will be a conflict when scheduler update queue using applystatus, this pr force update queu.status.allocated to solve this issue.
image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix queue update conflicts when upgrading to new version

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 31, 2025
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2025
@lowang-bh
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2025
@hwdef
Copy link
Member

hwdef commented May 31, 2025

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2025
@volcano-sh-bot volcano-sh-bot merged commit 88e8a80 into volcano-sh:release-1.12 May 31, 2025
15 checks passed
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JesseStutler
Copy link
Member

@Monokaix Please also cherry-pick it to release-1.11

dongjoon-hyun added a commit to apache/spark that referenced this pull request Jul 1, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `Volcano` to 1.12.1 in K8s integration test document and GA job.

### Why are the changes needed?

To bring the latest improvements and security fixes.
- https://github.com/volcano-sh/volcano/releases/tag/v1.12.1
  - volcano-sh/volcano#4336
- https://github.com/volcano-sh/volcano/releases/tag/v1.12.0
  - volcano-sh/volcano#4099
  - volcano-sh/volcano#3799
  - volcano-sh/volcano#4207
  - GHSA-hg79-fw4p-25p8

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #51343 from dongjoon-hyun/SPARK-52639.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
volcano-sh-bot added a commit that referenced this pull request Jul 13, 2025
…4336-origin-release-1.11

Automated cherry pick of #4336: Fix queue update conflicts when upgrading to new version
asl3 pushed a commit to asl3/spark that referenced this pull request Jul 14, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `Volcano` to 1.12.1 in K8s integration test document and GA job.

### Why are the changes needed?

To bring the latest improvements and security fixes.
- https://github.com/volcano-sh/volcano/releases/tag/v1.12.1
  - volcano-sh/volcano#4336
- https://github.com/volcano-sh/volcano/releases/tag/v1.12.0
  - volcano-sh/volcano#4099
  - volcano-sh/volcano#3799
  - volcano-sh/volcano#4207
  - GHSA-hg79-fw4p-25p8

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#51343 from dongjoon-hyun/SPARK-52639.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
haoyangeng-db pushed a commit to haoyangeng-db/apache-spark that referenced this pull request Jul 22, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `Volcano` to 1.12.1 in K8s integration test document and GA job.

### Why are the changes needed?

To bring the latest improvements and security fixes.
- https://github.com/volcano-sh/volcano/releases/tag/v1.12.1
  - volcano-sh/volcano#4336
- https://github.com/volcano-sh/volcano/releases/tag/v1.12.0
  - volcano-sh/volcano#4099
  - volcano-sh/volcano#3799
  - volcano-sh/volcano#4207
  - GHSA-hg79-fw4p-25p8

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#51343 from dongjoon-hyun/SPARK-52639.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants