-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix queue update conflicts when upgrading to new version #4336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Monokaix <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
@Monokaix Please also cherry-pick it to release-1.11 |
### What changes were proposed in this pull request? This PR aims to upgrade `Volcano` to 1.12.1 in K8s integration test document and GA job. ### Why are the changes needed? To bring the latest improvements and security fixes. - https://github.com/volcano-sh/volcano/releases/tag/v1.12.1 - volcano-sh/volcano#4336 - https://github.com/volcano-sh/volcano/releases/tag/v1.12.0 - volcano-sh/volcano#4099 - volcano-sh/volcano#3799 - volcano-sh/volcano#4207 - GHSA-hg79-fw4p-25p8 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51343 from dongjoon-hyun/SPARK-52639. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…4336-origin-release-1.11 Automated cherry pick of #4336: Fix queue update conflicts when upgrading to new version
### What changes were proposed in this pull request? This PR aims to upgrade `Volcano` to 1.12.1 in K8s integration test document and GA job. ### Why are the changes needed? To bring the latest improvements and security fixes. - https://github.com/volcano-sh/volcano/releases/tag/v1.12.1 - volcano-sh/volcano#4336 - https://github.com/volcano-sh/volcano/releases/tag/v1.12.0 - volcano-sh/volcano#4099 - volcano-sh/volcano#3799 - volcano-sh/volcano#4207 - GHSA-hg79-fw4p-25p8 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#51343 from dongjoon-hyun/SPARK-52639. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
### What changes were proposed in this pull request? This PR aims to upgrade `Volcano` to 1.12.1 in K8s integration test document and GA job. ### Why are the changes needed? To bring the latest improvements and security fixes. - https://github.com/volcano-sh/volcano/releases/tag/v1.12.1 - volcano-sh/volcano#4336 - https://github.com/volcano-sh/volcano/releases/tag/v1.12.0 - volcano-sh/volcano#4099 - volcano-sh/volcano#3799 - volcano-sh/volcano#4207 - GHSA-hg79-fw4p-25p8 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#51343 from dongjoon-hyun/SPARK-52639. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
In version before v1.12, queue update use applustatus of SSA and controller manage both queue.status.state and queue.status.allocated, and scheduler will also update queue.status.allocated, so there will be a conflict when scheduler update queue using applystatus, this pr force update queu.status.allocated to solve this issue.

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?