Skip to content

Conversation

@Monokaix
Copy link
Member

@Monokaix Monokaix commented Apr 22, 2025

What type of PR is this?

/area security

What this PR does / why we need it:

Part of #4170
Add http server timemout

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@volcano-sh-bot volcano-sh-bot added the area/security Issues or PRs related to security label Apr 22, 2025
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2025
@Monokaix Monokaix changed the title Add http server timeout [Security] Add http server timeout Apr 22, 2025
@hwdef
Copy link
Member

hwdef commented Apr 22, 2025

/lgtm
Need to handle CI.

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@Monokaix Monokaix force-pushed the timeout branch 2 times, most recently from b095a89 to 46f548f Compare April 24, 2025 01:15
Signed-off-by: Monokaix <[email protected]>
@hwdef
Copy link
Member

hwdef commented Apr 24, 2025

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
@volcano-sh-bot volcano-sh-bot merged commit 54801ac into volcano-sh:master Apr 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security Issues or PRs related to security lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants