Network topology scheduling implementations of volcano scheduler #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
do-not-merge/work-in-progress
volcano-sh-bot
added
the
size/XXL
Monokaix
force-pushed
the
network-topo
branch
3 times, most recently
from
6bb9f60 to
c9bf5f3
Compare
Monokaix
force-pushed
the
network-topo
branch
from
c9bf5f3 to
245dc6e
Compare
Monokaix
changed the title
volcano-sh-bot
removed
the
do-not-merge/work-in-progress
Monokaix
force-pushed
the
network-topo
branch
3 times, most recently
from
2b31b0c to
92c294a
Compare
volcano-sh-bot
added
the
needs-rebase
Signed-off-by: Monokaix <[email protected]>
Monokaix
force-pushed
the
network-topo
branch
from
92c294a to
727e2ca
Compare
volcano-sh-bot
removed
the
needs-rebase
Monokaix
force-pushed
the
network-topo
branch
from
727e2ca to
f47ae4f
Compare
lowang-bh
reviewed
Dec 22, 2024
| for _, op := range s.operations { | ||
| switch op.name { | ||
| case Evict: | ||
| buffer += fmt.Sprintf("task %s evict from node %s ", op.task.Name, op.task.NodeName) |
Member
There was a problem hiding this comment.
Does it need a ";" or "," to split each operation in log?
Member
Author
There was a problem hiding this comment.
There is aleady a space: )
lowang-bh
reviewed
Dec 22, 2024
Monokaix
force-pushed
the
network-topo
branch
from
f47ae4f to
0dcd8a4
Compare
added 2 commits
December 26, 2024 19:10
Signed-off-by: Monokaix <[email protected]>
Signed-off-by: Monokaix <[email protected]>
Monokaix
force-pushed
the
network-topo
branch
from
0dcd8a4 to
c01ead5
Compare
Member
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3873, #3850, please merge volcano-sh/apis#144 first.
It includes three parts:
Allocatechanges to support scheduler jobs with network topology constrains.