Patch Pod Annotations to Fix Potential Error #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches from using 'update' to 'patch' when setting pod annotations. The previous 'update' approach was found to potentially cause pod errors. By using 'patch', we now only modify the specific fields that have changed, preventing the previous issue. Signed-off-by: ronin <[email protected]>
This commit adds 'patch' permission to the clusterRole associated with our plugin. This change allows the plugin to patch pod annotations more safely, reducing the chance of errors and conflicts during updates. Signed-off-by: ronin <[email protected]>
…tes" This reverts commit 053d614. Signed-off-by: ronin <[email protected]>
This commit adds an error handler to catch and manage potential JSON encoding errors. By handling these errors explicitly, we can prevent crashes and improve the stability of the application. Signed-off-by: ronin <[email protected]>
papillonyi
force-pushed
the
fix-update-pod-fail
branch
from
66f0300 to
a8807c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug causing potential pod error by using patch for annotations
This pr switches from using 'update' to 'patch' when setting pod annotations. The previous 'update' approach was found to potentially cause pod errors. By using 'patch', we now only modify the specific fields that have changed, preventing the previous issue and improving efficiency.