Skip to content

Conversation

@dev-strender
Copy link

The title says it all.

@volcano-sh-bot
Copy link
Collaborator

Welcome @dev-strender! It looks like this is your first PR to volcano-sh/devices 🎉

@wangyang0616
Copy link
Member

Thanks for your contribution, please make CI happy.
See tips for repair method:

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Copy link
Contributor

@Thor-wl Thor-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM for me except for the DCO check.

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Thor-wl
To complete the pull request process, please assign william-wang after the PR has been reviewed.
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dev-strender
Copy link
Author

/assign @william-wang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants