Skip to content

Conversation

@piotrtomiak
Copy link
Contributor

Angular plugin is transpiling the TS files. Within getScriptSnapshot there is a code which associated scrip info with a project. Without this call, scripts are orphaned and wrong config is used during highlighting. Not sure if this fix should apply to all types of files though

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 5, 2024

Open in Stackblitz

@volar/eslint

npm i https://pkg.pr.new/volarjs/volar.js/@volar/eslint@250

@volar/language-core

npm i https://pkg.pr.new/volarjs/volar.js/@volar/language-core@250

@volar/kit

npm i https://pkg.pr.new/volarjs/volar.js/@volar/kit@250

@volar/language-server

npm i https://pkg.pr.new/volarjs/volar.js/@volar/language-server@250

@volar/language-service

npm i https://pkg.pr.new/volarjs/volar.js/@volar/language-service@250

@volar/monaco

npm i https://pkg.pr.new/volarjs/volar.js/@volar/monaco@250

@volar/source-map

npm i https://pkg.pr.new/volarjs/volar.js/@volar/source-map@250

@volar/jsdelivr

npm i https://pkg.pr.new/volarjs/volar.js/@volar/jsdelivr@250

@volar/test-utils

npm i https://pkg.pr.new/volarjs/volar.js/@volar/test-utils@250

@volar/typescript

npm i https://pkg.pr.new/volarjs/volar.js/@volar/typescript@250

@volar/vscode

npm i https://pkg.pr.new/volarjs/volar.js/@volar/vscode@250

commit: a938860

@johnsoncodehk
Copy link
Member

Thanks! This is a regression introduced in #226. I made some adjustments to this PR to make sure the fix happens in the right place, we may need to adjust the API design to better accommodate this TS behavior.

@johnsoncodehk johnsoncodehk merged commit d239d91 into volarjs:master Dec 13, 2024
5 checks passed
@piotrtomiak
Copy link
Contributor Author

@johnsoncodehk Thanks a lot for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants