Fix #97 -- Properly parse domain names in markdown links#98
Merged
Conversation
amureki
force-pushed
the
97/domain-parsing
branch
from
9e5a5b3 to
7288a06
Compare
codingjoe
approved these changes
Aug 23, 2024
Collaborator
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
This is going to introduce IO, but it is probably the best solution… since apparently germany is a valid domain name… who know this internet thing would ever succeed
Co-authored-by: Johannes Maron <johannes@maron.family>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is described in #97.
I had to introduce a library - tldextract to properly parse all varieties of domain names.