Skip to content

Do not track external clicks#48

Merged
amureki merged 2 commits into
mainfrom
do-not-track-external-clicks
Jul 28, 2023
Merged

Do not track external clicks#48
amureki merged 2 commits into
mainfrom
do-not-track-external-clicks

Conversation

@amureki
Copy link
Copy Markdown
Member

@amureki amureki commented Jul 26, 2023

Wrapping external links is not making sense as tracking view does not allow that and fails with HTTP 400 (Missing url or malformed parameter)

@amureki amureki self-assigned this Jul 26, 2023
@amureki amureki force-pushed the do-not-track-external-clicks branch from 4877e05 to ab0b7ff Compare July 26, 2023 08:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (db8ea55) 100.00% compared to head (39ef419) 100.00%.

❗ Current head 39ef419 differs from pull request most recent head 3d50718. Consider uploading reports for the commit 3d50718 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10         9    -1     
  Lines          360       350   -10     
=========================================
- Hits           360       350   -10     
Files Changed Coverage Δ
emark/message.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amureki amureki requested a review from codingjoe July 26, 2023 08:14
@codingjoe
Copy link
Copy Markdown
Collaborator

@amureki you will need to rebase this.

@amureki amureki force-pushed the do-not-track-external-clicks branch from 39ef419 to 61345d8 Compare July 28, 2023 13:34
@amureki amureki force-pushed the do-not-track-external-clicks branch from 61345d8 to 3d50718 Compare July 28, 2023 13:37
@amureki amureki merged commit 6fd0b4d into main Jul 28, 2023
@amureki amureki deleted the do-not-track-external-clicks branch July 28, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants