Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 4 9 +5
Lines 172 313 +141
==========================================
+ Hits 172 313 +141
☔ View full report in Codecov by Sentry. |
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
Awesome feature!
I have first comments here, but I still need to do the testing part.
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
Also, as you mentioned - we need to think about rate limiting.
Co-authored-by: Rust Saiargaliev <fly.amureki@gmail.com>
Co-authored-by: Rust Saiargaliev <fly.amureki@gmail.com>
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
Shall we do a beta release first?
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
I did some tests, found a couple of things. Also, tracking is questionable, we'd need to test how it works in comparison to the mailing systems like Brevo, as here are the results from my test:
- checking an email via gmail (no ad-blockers) in browser does not count as opening
- gmail on iOS also does not count at all
- Microsoft Windows 10 Mail does not count at all
- MacOS Mail.app open counts as 1 open (no matter how many times you will open it)
| self.language = language | ||
| utm_params = utm_params or {} | ||
| self.utm_params = utm_params or {} | ||
| self.subject = subject or self.subject |
There was a problem hiding this comment.
When called via to_user, like:
LoginEmail.to_user(user, context).send()
... the subject is being omitted completely, so I am getting None there instead of the one defined in the class.
Co-authored-by: Rust Saiargaliev <fly.amureki@gmail.com>
codingjoe
force-pushed
the
tracking
branch
3 times, most recently
from
7cce520 to
2c246f1
Compare
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
flake8 complained about something
| {% if tracking_pixel_url %} | ||
| .main { | ||
| background-image: url("{{ tracking_pixel_url }}"); | ||
| } | ||
| {% endif %} |
There was a problem hiding this comment.
Something is odd here with gmail desktop - tracking does not work there.
I wonder if premailer does not handle this style setting correctly.
Shall we try just adding a pixel to html directly?
Tracking in mail.app and gmail mobile works.
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
@codingjoe switching to <img> worked, opens are tracked in gmail desktop, as well as in the other clients.
So, from my side this is good to go now!
2 participants
Uh oh!
There was an error while loading. Please reload this page.