Skip to content

Conversation

@bjoaquinc
Copy link
Collaborator

@bjoaquinc bjoaquinc commented Feb 10, 2025

Description:

Fixes bugs related to compiling and building void-server or the remote host to be used by open-remote-ssh extension by

  • Fixes this error:
    Error: Command failed: npm ls --all --omit=dev --parseable npm ERR! code ELSPROBLEMS npm ERR! extraneous: @parcel/node-addon-api@ /Users/joaquincoromina/projects/void/react-ssh-extension/void/remote/node_modules/@parcel/node-addon-api npm ERR! missing: tslib@*, required by @microsoft/[email protected]
    which can be replicated by running npm ls --all --omit=dev --parseable in /remote
  • Updating the output directory to be void-reh-{{PLATFORM}}-{{ARCH}} instead of vscode-reh-{{PLATFORM}}-{{ARCH}}

Issue:

Partially addresses #209 by fixing the compilation process of the void remote host which can then be included in the output files of void-remote-updates, and used by the Remote-SSH extension.


Important

Fixes build issues by adding tslib dependency and updates output directory naming to void-reh in remote/package.json.

  • Build Fixes:
    • Adds tslib dependency to remote/package.json to resolve missing dependency error during build.
    • Updates output directory naming from vscode-reh-{{PLATFORM}}-{{ARCH}} to void-reh-{{PLATFORM}}-{{ARCH}}.
  • Issue Reference:
    • Partially addresses issue SSH Integration #209 by fixing the compilation process for the void remote host.

This description was created by Ellipsis for 6f6f43c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6f6f43c in 21 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 2 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. remote/package.json:36
  • Draft comment:
    Verify that the added 'tslib' version (^2.8.1) is compatible with other dependencies, especially with @microsoft/applicationinsights-core-js. This change fixes the npm error, but please confirm version alignment across packages.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. remote/package.json:36
  • Draft comment:
    Added missing 'tslib' dependency (^2.8.1) to address the npm error. Confirm that this version meets the requirements of packages like @microsoft/applicationinsights-core-js.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None

Workflow ID: wflow_9DOqmHu3Ea6zajDN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants