Potential fix for code scanning alert no. 26: Unsafe shell command constructed from library input #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/vmware/vrealize-developer-tools/security/code-scanning/26
To fix this issue, we need to ensure that untrusted input (
workflowsPath, as well as any other interpolated data) does not cause unexpected behavior or command injection when constructing and executing shell commands. The general approach is to avoid concatenating unsanitized inputs into shell command strings. There are two options:child_process.execFileor equivalent), so that arguments are properly escaped and not interpreted by the shell.shell-quote.In this context, since the command seems not to require shell-specific features (no pipes, redirection, etc.), the best fix is to construct an argument array and use
proc.execFileinstead ofproc.exec, passing input as arguments. This entails:proc.execto useproc.execFile(or equivalent), or refactoringproc.execitself if it wraps both kinds of execution.workflowsPath,groupId,artifactId, etc.) are passed as array elements rather than interpolated into a string.Necessary changes are limited to the
createProjectmethod inMavenCliProxy.ts:proc.execFile(presuming it exists and functions like Node’schild_process.execFile).If the
procmodule does not already support execFile, you may need to implement that or, minimally, adjustproc.execto allow array arguments (but only within the shown code).Suggested fixes powered by Copilot Autofix. Review carefully before merging.