airflow-provider-vdk: VDKSensor initial structure #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change lays out the initial structure for the VDK asynchronous operator, a.k.a. the VDKSensor. The purpose of this sensor is to routinely poke the VDK control-service and check the status of a particular job, so that its completion/failure can trigger some activity in an Airflow DAG, i.e. trigger another job. Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
doks5
suggested changes
Apr 12, 2022
Contributor
doks5
left a comment
doks5
left a comment
There was a problem hiding this comment.
Maybe add some docstrings about what the sensor is supposed to do. No need to be detailed (as it would be improved during the implementation process), just some high-level information.
projects/vdk-plugins/airflow-provider-vdk/tests/sensors/test_vdksensor.py
Show resolved
Hide resolved
mivanov1988
reviewed
Apr 13, 2022
mivanov1988
approved these changes
Apr 14, 2022
doks5
approved these changes
Apr 14, 2022
Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lays out the initial structure for the VDK asynchronous
operator, a.k.a. the VDKSensor. The purpose of this sensor is to
routinely poke the VDK control-service and check the status of a
particular job, so that its completion/failure can trigger some
activity in an Airflow DAG, i.e. trigger another job.
Signed-off-by: Gabriel Georgiev [email protected]