control-service: Adopt use of the V1CronJob API #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
…on/gageorgiev/jobs-cleanup
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
To allow for the automatic job clean up of manually ran data jobs and builder jobs, the VDK control service must use the V1CronJob API. However, V1CronJobs are available from Kubernetes 1.21 onwards, and VDK must be able to run on older versions of Kubernetes. This change manages this by duplicating relevant methods, and relying on a feature flag to determine whether the Kubernetes cluster supports V1CronJobs, and defaulting back to V1beta1CronJobs in the case where it does not. Testing done: TBD Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
…on/gageorgiev/jobs-cleanup Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
…rsatile-data-kit into person/gageorgiev/jobs-cleanup Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
ivakoleva
reviewed
Mar 16, 2022
...pipelines_control_service/src/test/java/com/vmware/taurus/service/KubernetesServiceTest.java
Show resolved
Hide resolved
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Outdated
Show resolved
Hide resolved
...rol_service/src/main/java/com/vmware/taurus/service/kubernetes/ControlKubernetesService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
antoniivanov
approved these changes
Mar 18, 2022
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
ivakoleva
pushed a commit
that referenced
this pull request
Mar 22, 2022
To allow for the automatic job clean up of manually ran data jobs and builder jobs, the VDK control service must use the V1CronJob API. However, V1CronJobs are available from Kubernetes 1.21 onwards, and VDK must be able to run on older versions of Kubernetes. This change manages this by duplicating relevant methods, and relying on a feature flag to determine whether the Kubernetes cluster supports V1CronJobs, and defaulting back to V1beta1CronJobs in the case where it does not. Testing done: all existing unit and intergration tests pass, added unit tests Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for the automatic job clean up of manually ran data jobs
and builder jobs, the VDK control service must use the V1CronJob
API. However, V1CronJobs are available from Kubernetes 1.21 onwards,
and VDK must be able to run on older versions of Kubernetes.
This change manages this by duplicating relevant methods, and relying
on a feature flag to determine whether the Kubernetes cluster supports
V1CronJobs, and defaulting back to V1beta1CronJobs in the case where
it does not.
Testing done: all existing unit and intergration tests pass, added unit tests
Signed-off-by: Gabriel Georgiev [email protected]