vdk-core: enable/disable structlog based on config #3102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? vdk-structlog has a default config flag set to True when installed. It relegates all logging configuration to the plugin and is cheked in core, i.e. if structlog is installed, vdk will use structlog. If it's not installed, it will use the configuration available in core. The flag is currently checked using an env variable, which makes it not work. What? Check the flag using the config object How was this tested? Manually What kind of change is this? Bugfix Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
duyguHsnHsn
approved these changes
Feb 14, 2024
yonitoo
approved these changes
Feb 14, 2024
yonitoo
pushed a commit
that referenced
this pull request
Feb 15, 2024
## Why? vdk-structlog has a default config flag set to True when installed. It relegates all logging configuration to the plugin and is checked in core, i.e. if structlog is installed, vdk will use structlog. If it's not installed, it will use the configuration available in core. The flag is currently checked using an env variable, which makes it not work. ## What? Check the flag using the config object ## How was this tested? Manually ## What kind of change is this? Bugfix Signed-off-by: Dilyan Marinov <mdilyan@vmware.com> Co-authored-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
vdk-structlog has a default config flag set to True when installed. It relegates all logging configuration to the plugin and is checked in core, i.e. if structlog is installed, vdk will use structlog. If it's not installed, it will use the configuration available in core. The flag is currently checked using an env variable, which makes it not work.
What?
Check the flag using the config object
How was this tested?
Manually
What kind of change is this?
Bugfix