Improved healt.sh, added health.ps, added instruction for use under win #922
Conversation
github-actions
bot
added
the
kind/enhancement
Zdravko-Genov
force-pushed
the
improvemnt-of-healt-script
branch
from
a3aec68 to
b0135b4
Compare
|
@Zdravko-Genov thank you for your contribution! I will try to do a more in-depth check soon, for now I will just leave small comments regarding the dependencies I saw |
| @{ name = "Node.js"; cmd="node --version"; min="12.0"; max="24.0" }, | ||
| @{ name = "Python"; cmd="python --version"; min="3.2"; max="3.14" }, | ||
| @{ name = "Pip"; cmd="pip --version"; min="25.0"; max="26.0" }, | ||
| @{ name = "OpenSSL"; cmd="openssl version"; min="10.0"; max="17.0" } |
There was a problem hiding this comment.
I think openssl shouldn't be required. If you encountered it in the instructions for generating an certificates for signing the Orchestrator packages this is meant to be just an example on how you can generate it. The prereq is having that certificate for signing packages and is only for Orchestrator projects but they can be generated in other ways including from external system and may also not be present on the system that is building the project but can be located in an artifactory.
| @{ name = "Java"; cmd="java --version"; min="17.0"; max="24.0" }, | ||
| @{ name = "Maven"; cmd="mvn --version"; min="3.2"; max="4.0" }, | ||
| @{ name = "Node.js"; cmd="node --version"; min="12.0"; max="24.0" }, | ||
| @{ name = "Python"; cmd="python --version"; min="3.2"; max="3.14" }, |
There was a problem hiding this comment.
Python and pip are not required by default. Have in mind that the prereqs are not for building BTVA project itself but for building the projects generated by it's archetypes, e.g. vro js, vro ts, vra-ng, etc.
The general dependencies for all of them are mvn, java and node.
There is 1 specific project type that has additional dependencies - the polyglot (and abx) type of project supports the 3 types of actions, supported by vro - node, powershell and python. Based on the choosen action runtime you might need python or powershell as dependency.
So based on that I need to check with the team on how we want to handle this - throwing an error for missing python dependency on a regular JS based project would be misleading. maybe we can add a warning message for python and powershell that they might be required for polyglot project types.
| @( | ||
| @{ name = "Java"; cmd="java --version"; min="17.0"; max="24.0" }, | ||
| @{ name = "Maven"; cmd="mvn --version"; min="3.2"; max="4.0" }, | ||
| @{ name = "Node.js"; cmd="node --version"; min="12.0"; max="24.0" }, |
There was a problem hiding this comment.
For node currently the officially supported version is 22. Some lower versions might work in specific use cases but it is situational so that cannot be officially supported.
| # OpenSSL is not following the guidelines | ||
| @( | ||
| @{ name = "Java"; cmd="java --version"; min="17.0"; max="24.0" }, | ||
| @{ name = "Maven"; cmd="mvn --version"; min="3.2"; max="4.0" }, |
There was a problem hiding this comment.
For maven it is a bit hard to say since maven seems to be more flexible, I've tested with 3.6 - 3.9. but don't know about other versions.
2 participants
Description
Made a few improvements:
❓ I need some help determine the dependencies and the respective versions.
❗ I noticed there is a dependencies on OpenSSL and Python. They are generally present in Linux, but not on Win.
Checklist - none of those seems applicable ( at this point )
Fixed #XXX -orClosed #XXX -prefix to auto-close the issueTesting
Locally tested
Release Notes
Related issues and PRs