Skip to content

ECR Keyless access - deps bumped and changed to k8schain#78

Merged
rashedkvm merged 1 commit intovmware-tanzu:main-v0.7.xfrom
rashedkvm:ecr-0.7.x
May 4, 2023
Merged

ECR Keyless access - deps bumped and changed to k8schain#78
rashedkvm merged 1 commit intovmware-tanzu:main-v0.7.xfrom
rashedkvm:ecr-0.7.x

Conversation

@rashedkvm
Copy link
Copy Markdown
Member

@rashedkvm rashedkvm commented May 3, 2023

Pull request

What this PR does / why we need it

Tanzu Source Controller on EKS with ECR as a registry and auth against ECR via IAM role, the request fails.

Which issue(s) this PR fixes

Fixes #77

Describe testing done for PR

Manual testing on an EKS cluster with ECR

k get imagerepositories.source.apps.tanzu.vmware.com -A
NAMESPACE   NAME                      IMAGE                                                                                                   URL                                                                                                                                                                                                          READY   REASON   AGE
default     imagerepository-dkrhb     XXXXXXXX/tanzu-hava-app-image@sha256:185ec690a4fa84328ac97b6fe021974c9313859a9a87f3b8a2b8131982544e8f   http://source-controller-manager-artifact-service.source-system.svc.cluster.local./imagerepository/default/imagerepository-dkrhb/185ec690a4fa84328ac97b6fe021974c9313859a9a87f3b8a2b8131982544e8f.tar.gz     True    Ready    17m
default     imagerepository-no-auth   XXXXXXXXXX.dkr.ecr.us-east-2.amazonaws.com/tsc-test-repo:dev                                            http://source-controller-manager-artifact-service.source-system.svc.cluster.local./imagerepository/default/imagerepository-no-auth/185ec690a4fa84328ac97b6fe021974c9313859a9a87f3b8a2b8131982544e8f.tar.gz   True    Ready    17m

Additional information or special notes for your reviewer

  • ECR Keyless access - deps bumped and changed to k8schain
  • Switched to k8schain from Kubernetes pkg

@rashedkvm rashedkvm marked this pull request as ready for review May 4, 2023 01:52
rszumlakowski
rszumlakowski previously approved these changes May 4, 2023
katmutua
katmutua previously approved these changes May 4, 2023
@rashedkvm rashedkvm dismissed stale reviews from katmutua and rszumlakowski via 3713994 May 4, 2023 13:35
@rashedkvm rashedkvm merged commit e8e0441 into vmware-tanzu:main-v0.7.x May 4, 2023
@rashedkvm rashedkvm deleted the ecr-0.7.x branch May 4, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants