Update readme and contributing documentation#24
Merged
rashedkvm merged 1 commit intovmware-tanzu:mainfrom Feb 13, 2023
rashedkvm:ospo-comments
Merged
Update readme and contributing documentation#24rashedkvm merged 1 commit intovmware-tanzu:mainfrom rashedkvm:ospo-comments
rashedkvm merged 1 commit intovmware-tanzu:mainfrom
rashedkvm:ospo-comments
Conversation
heyjcollins
reviewed
Feb 13, 2023
heyjcollins
previously approved these changes
Feb 13, 2023
heyjcollins
left a comment
heyjcollins
left a comment
There was a problem hiding this comment.
I approve with the assumption that my minor suggestion be considered - although I don't think the suggested change should block approval.
Signed-off-by: Rashed Kamal <krashed@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rashed Kamal krashed@vmware.com
Pull request
What this PR does / why we need it
Update readme and contributing documentation based on OSPO recommendation
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Additional information or special notes for your reviewer