This repository was archived by the owner on Nov 17, 2021. It is now read-only.
Add support for Google Container Registry - #225
Merged
Conversation
Add Google Container Registry support Fix jsonnet tests
anguslees
approved these changes
Sep 2, 2018
anguslees
left a comment
anguslees
left a comment
Contributor
There was a problem hiding this comment.
I had some trivial comments, so I just made those changes directly.
Nice improvement, thanks!
| "strings" | ||
|
|
||
| "github.com/genuinetools/reg/repoutils" | ||
|
|
Contributor
There was a problem hiding this comment.
Remove this blank line between the 3rd party imports
Oops, turns out it _is_ still used.
Contributor
|
Urgh, every time I use the github editor to make "obvious" changes without being able to test them first, I make things worse :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original resolver implementation in
kubecfgwas not working with protected Google Container Registry repositories. It was failing with 401 Unauthorized response code, even thoughdocker pullfor the same image is working fine.This PR changes the RegistryResolver implementation by using a pretty solid external package of container registry utilities: https://github.com/genuinetools/reg.
I removed the
utils/resolver_test.gofile as it is not relevant that much anymore since external package is used.This issue was a real blocker for us for using
kubecfg, as we rely very heavily on deployments by the exact image digest.