[BugFix] Fix chat API continuous usage stats #9357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- completion_tokens in returned continuous usage stats was not cumulative as it should be. - completion_tokens in the final usage stats should be the total for all choices. - Includes some related code simplification/deduplication.
njhill
force-pushed
the
fix-chat-stream-usage
branch
from
fcb0d5e to
558e3a3
Compare
njhill
requested review from
DarkLight1337,
robertgshaw2-redhat and
simon-mo
as code owners
DarkLight1337
approved these changes
Oct 15, 2024
Member
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Entrypoints tests pass, so this should be good to go!
njhill
added a commit
to njhill/vllm
that referenced
this pull request
Oct 17, 2024
Similar to what was done for the chat API in vllm-project#9357. Ensure that the final chunk with usage data contains aggregate counts across all choices. Also simplify some of the prompt-handling logic in the API implementation.
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Alvant <[email protected]>
garg-amit
pushed a commit
to garg-amit/vllm
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Amit Garg <[email protected]>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
Signed-off-by: qishuai <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Sumit Dubey <[email protected]>
LeiWang1999
pushed a commit
to LeiWang1999/vllm-bitblas
that referenced
this pull request
Mar 26, 2025
Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an omission in the changes I made recently in the delta-streaming optimization #7381.