Skip to content

[CI/Build][Bugfix][Doc][ROCm] CI fix and doc update after ROCm 6.2 upgrade #8777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 5 commits into from
Sep 25, 2024
Merged

[CI/Build][Bugfix][Doc][ROCm] CI fix and doc update after ROCm 6.2 upgrade #8777

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e244aaf
[ROCm] minor doc update
hongxiayang Sep 24, 2024
e21d833
Update docs/source/getting_started/amd-installation.rst
hongxiayang Sep 24, 2024
e5a40e8
package needed for pytest in CI to support shards
hongxiayang Sep 24, 2024
610693d
Merge branch 'small_cleanup' of https://github.com/hongxiayang/vllm i…
hongxiayang Sep 24, 2024
1773958
fix amd entrypoints hip OOM failure
hongxiayang Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion docs/source/getting_started/amd-installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ Option 1: Build from source with docker (recommended)
You can build and install vLLM from source.

First, build a docker image from `Dockerfile.rocm <https://github.com/vllm-project/vllm/blob/main/Dockerfile.rocm>`_ and launch a docker container from the image.
It is important that the user kicks off the docker build using buildkit. Either the user put DOCKER_BUILDKIT=1 as environment variable when calling docker build command, or the user needs to setup buildkit in the docker daemon configuration /etc/docker/daemon.json as follows and restart the daemon:

.. code-block:: console

{
"features": {
"buildkit": true
}
}


`Dockerfile.rocm <https://github.com/vllm-project/vllm/blob/main/Dockerfile.rocm>`_ uses ROCm 6.2 by default, but also supports ROCm 5.7, 6.0 and 6.1 in older vLLM branches.
It provides flexibility to customize the build of docker image using the following arguments:
Expand Down Expand Up @@ -152,7 +162,7 @@ Note to get your gfx architecture, run `rocminfo |grep gfx`.
$ python3 setup.py develop


This may take 5-10 minutes. Currently, `pip install .`` does not work for ROCm installation
This may take 5-10 minutes. Currently, `pip install .` does not work for ROCm installation.


.. tip::
Expand Down