Skip to content

[Bugfix] Bind api server port before starting engine #8491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2024
Merged

[Bugfix] Bind api server port before starting engine #8491

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62fd8d7
Bind remote server to port 0
kevin314 Sep 14, 2024
42b9a1e
Revert "Bind remote server to port 0"
kevin314 Sep 15, 2024
2bac8b1
Set VLLM_PORT env variable
kevin314 Sep 15, 2024
9d4a07c
Run linter
kevin314 Sep 15, 2024
103957f
Trigger Build
kevin314 Sep 15, 2024
4558420
Revert "Set VLLM_PORT env variable"
kevin314 Sep 16, 2024
44aea07
Bind api server port before starting engine
kevin314 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions vllm/entrypoints/openai/api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import os
import re
import signal
import socket
import tempfile
from argparse import Namespace
from contextlib import asynccontextmanager
Expand Down Expand Up @@ -525,6 +526,9 @@ async def run_server(args, **uvicorn_kwargs) -> None:
logger.info("vLLM API server version %s", VLLM_VERSION)
logger.info("args: %s", args)

temp_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
temp_socket.bind(("", args.port))
Copy link

@piamo piamo Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may disable listening on ipv6 address


def signal_handler(*_) -> None:
# Interrupt server on sigterm while initializing
raise KeyboardInterrupt("terminated")
Expand All @@ -541,6 +545,8 @@ def signal_handler(*_) -> None:
model_config = await async_engine_client.get_model_config()
init_app_state(async_engine_client, model_config, app.state, args)

temp_socket.close()

shutdown_task = await serve_http(
app,
limit_concurrency=async_engine_client.limit_concurrency,
Expand Down