Skip to content

Conversation

@comaniac
Copy link
Collaborator

@comaniac comaniac commented Sep 3, 2024

cc @robertgshaw2-neuralmagic @mgoin @pavanimajety @jon-chuang

@jon-chuang
Copy link
Contributor

jon-chuang commented Sep 3, 2024

I guess this will circumvent #8051 and ignore that particular case; simply test on a smaller subset of models

@comaniac
Copy link
Collaborator Author

comaniac commented Sep 3, 2024

I guess this will circumvent #8051 and ignore that particular case; simply test on a smaller subset of models

Yeah I don't think we need to test that model for this test.

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 4, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavanimajety
Copy link
Collaborator

LGTM, thanks for the test!

@comaniac comaniac enabled auto-merge (squash) September 4, 2024 17:16
@comaniac comaniac disabled auto-merge September 4, 2024 17:16
@comaniac comaniac enabled auto-merge (squash) September 4, 2024 17:39
@comaniac comaniac merged commit 2ad2e56 into vllm-project:main Sep 4, 2024
@comaniac comaniac deleted the refactor-fp8-test branch September 4, 2024 19:03
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants