[Bugfix] neuron: enable tensor parallelism #7562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: omrishiv <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
simon-mo
approved these changes
Aug 15, 2024
Collaborator
simon-mo
left a comment
simon-mo
left a comment
There was a problem hiding this comment.
stamping args_utils changes.
Signed-off-by: omrishiv <[email protected]>
Signed-off-by: omrishiv <[email protected]>
Signed-off-by: omrishiv <[email protected]>
Signed-off-by: omrishiv <[email protected]>
liangfu
approved these changes
Aug 23, 2024
vllm/worker/neuron_worker.py
Outdated
| self.is_driver_worker = True | ||
|
|
||
| def init_device(self) -> None: | ||
| os.environ["PJRT_DEVICE"] = "NEURON" |
Contributor
Author
|
@liangfu Thank you, leftover from testing. Removed |
github-actions
bot
added
the
ready
auto-merge was automatically disabled
August 26, 2024 18:12
Head branch was pushed to by a user without write access
omrishiv
force-pushed
the
neuron-tensor-parallelism
branch
from
b00c3fe to
6cfdae3
Compare
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: omrishiv <[email protected]> Signed-off-by: Alvant <[email protected]>
LeiWang1999
pushed a commit
to LeiWang1999/vllm-bitblas
that referenced
this pull request
Mar 26, 2025
Signed-off-by: omrishiv <[email protected]> Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILL IN THE PR DESCRIPTION HERE
FIX #6269
Following #7175, this enables tensor parallelism on neuron with vLLM > 0.5.0. The
block-sizechoices are also reverted back to the previous values and vLLM will take themax-model-lenas theblock-sizeon neuron devices.