[CI/Build][ROCm] Enabling LoRA tests on ROCm #7369

akondrat-amd · 2024-08-09T15:42:29Z

FILL IN THE PR DESCRIPTION HERE

FIX #xxxx (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

github-actions · 2024-08-09T15:42:41Z

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

Comment /ready on the PR
Add ready label to the PR
Enable auto-merge.

🚀

jeejeelee · 2024-08-09T16:03:34Z

.buildkite/test-pipeline.yaml

- csrc/punica is unused，could you please delete it, thank you

Thanks, line 314 should also be deleted

akondrat-amd · 2024-08-14T05:01:01Z

/ready

khluu · 2024-08-19T22:57:53Z

Is this PR ready to be merged or do you need to run full CI suite? If not, can we remove ready label? If you just want to run AMD tests, you can unblock them in fastcheck.

akondrat-amd · 2024-08-21T15:14:46Z

Is this PR ready to be merged or do you need to run full CI suite? If not, can we remove ready label? If you just want to run AMD tests, you can unblock them in fastcheck.

I needed to run the full CI suite for AMD tests, but it would be nice to have an option to temporarily disable NVIDIA tests. I'm done with this PR and will not be committing to this branch anymore.

…ine.yaml

…S, temporary disabling LoRA tests

simon-mo · 2024-08-29T22:59:58Z

.buildkite/run-amd-test.sh

+PARALLEL_JOB_COUNT=8
+#check if the command contains shard flag
+if [[ $commands == *"--shard-id="* ]]; then
+  for GPU in $(seq 0 $(($PARALLEL_JOB_COUNT-1))); do


This is an incorrect implementation of the sharding. Buildkite should already started X number of jobs under the same name. Each run script should just receive the environment variable, and pass it along to the command.

The current implementation is trying to run all shards in the same command

in more detail, it looks like the they are indeed running in the same job in parallel
https://buildkite.com/vllm/ci-aws/builds/7784#01919a58-e1eb-48b3-9fd5-872f0328e913

this might break more often than we wanted?

This invocation is compatible with the general way we launch tests. IMHO unless there is a problem with execution of the "payload" tests, we shouldn't be restricted in the way we implement the invocation logic.

Our engineering choices are dictated by the specific nature of our HW infrastructure and its initialization/decoupling.

We cannot use docker Buildkite plugin, so we have parallelize the jobs ourselves. Our shell script receives the command with empty "--shard-id=" argument, so we have to substitute it and run as background jobs while exposing one GPU to each job.

sorry how many GPUs is there on each node? You can run multiple buildkite agent on the host and pin each to a GPU using environment variable. This can drastically help accelerate the test

my main concern with this approach is now the way sharding is handling is implemented differently and can cause issues when developers are debugging the test failures on amd devices.

We cannot use docker Buildkite plugin
Can I ask what's the reason? For for sharding, it is not necessary to use the plugin. Sharding is a native option. see https://buildkite.com/docs/tutorials/parallel-builds

Each node has 8 GPUs. The restarting procedure is indiscriminate though,- we're restarting all GPUs on a given node at once. This strategy has advantage of complete between-test decoupling. The unfortunate downside is that we can't rely on multiple Buildkite agents running on the same host.

We achieved the current level of HW stability with this approach.

Got it. Let's refine this PR a bit and we can merge it in

simon-mo · 2024-09-03T20:32:06Z

.buildkite/run-amd-test.sh

@@ -1,5 +1,6 @@
 # This script runs test inside the corresponding ROCm docker container.
-set -ex
+#set -ex


.buildkite/run-amd-test.sh

Co-authored-by: Simon Mo <[email protected]>

Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Alvant <[email protected]>

Co-authored-by: Simon Mo <[email protected]> Signed-off-by: LeiWang1999 <[email protected]>

jeejeelee reviewed Aug 9, 2024

View reviewed changes

WoosukKwon added the rocm Related to AMD ROCm label Aug 9, 2024

github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 14, 2024

akondrat-amd force-pushed the lora_test_enablement branch from 36022ad to 302b075 Compare August 20, 2024 14:24

akondrat-amd and others added 22 commits August 22, 2024 23:33

Modifying test_quant_model.py, AWQ is not supported on ROCm

31655b7

xfailing Gemma test for further investigation

26d8429

Enabling LoRA tests for AMD in Buildkite

670e3c6

Adding reason for Gemma test xfail

a58f019

Fixing MODELS re-definition

39f9bec

Removing - csrc/punica for LoRA dependancies

d8207ed

Sorting imports

df0efb1

Update alignment

a4f78e5

Make yapf happy

91ce9c4

Update test_quant_model.py

32f3a10

Update test_quant_model.py

a103778

Make yapf(3.11) happy

1d35abb

Removing csrc/punica dependency for LoRA long context test test-pipel…

1d1a86c

…ine.yaml

Exposing single GPU to the container

85f76e9

Passing Bildkite env vars to container for pytest

23017cc

Explicitly setting number of parallel jobs(shards in pytest) to 1

d7cde25

Removing unused arguments in test shell script

f7794a6

Placing the quotes around the test commands

d371265

Remove single quotes

f853c58

Automatically replacing CUDA_VISIBLE_DEVICES with HIP_VISIBLE_DEVICE…

fa9f388

…S, temporary disabling LoRA tests

trying to run four instances in parallel

64f12e4

adding GPU number to container name

dfb0e4c

akondrat-amd and others added 7 commits August 22, 2024 23:33

Re-enabling LoRA tests

27f6e00

Running four docker processes in parallel

bbe7696

Using pipefail option to propagate the error code

46682e3

Run 8 parallel jobs

b3fc101

Fixing pipe operator

dd12ded

Removing comment

6c43c65

Merge remote-tracking branch 'upstream/main' into lora_test_enablement

5c6cdc3

akondrat-amd force-pushed the lora_test_enablement branch from ebc3efe to 5c6cdc3 Compare August 23, 2024 14:38

Resolving conflict in run-amd-test.sh and merging with main

c48c569

simon-mo reviewed Aug 29, 2024

View reviewed changes

simon-mo approved these changes Sep 3, 2024

View reviewed changes

akondrat-amd and others added 2 commits September 3, 2024 16:47

Update comment in .buildkite/run-amd-test.sh

16ea3cf

Co-authored-by: Simon Mo <[email protected]>

Removed commented out string run-amd-test.sh

1de52bd

simon-mo merged commit d1dec64 into vllm-project:main Sep 4, 2024

akondrat-amd deleted the lora_test_enablement branch September 11, 2024 01:40

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024

[CI/Build][ROCm] Enabling LoRA tests on ROCm (vllm-project#7369)

cfaf3d1

Co-authored-by: Simon Mo <[email protected]> Signed-off-by: Alvant <[email protected]>

DarkLight1337 mentioned this pull request Nov 9, 2024

[Build/CI] Extending AMD Tests #4875

Closed

LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025

[CI/Build][ROCm] Enabling LoRA tests on ROCm (vllm-project#7369)

c254e67

Co-authored-by: Simon Mo <[email protected]> Signed-off-by: LeiWang1999 <[email protected]>

Uh oh!

[CI/Build][ROCm] Enabling LoRA tests on ROCm #7369

[CI/Build][ROCm] Enabling LoRA tests on ROCm #7369

Uh oh!

Conversation

akondrat-amd commented Aug 9, 2024

PR Title and Classification

Code Quality

Notes for Large Changes

What to Expect for the Reviews

Thank You

Uh oh!

github-actions bot commented Aug 9, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeejeelee Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akondrat-amd commented Aug 14, 2024

Uh oh!

khluu commented Aug 19, 2024

Uh oh!

akondrat-amd commented Aug 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jeejeelee Aug 12, 2024 •

edited

Loading