Skip to content

[Bugfix] Specify device when loading LoRA and embedding tensors #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youkaichao merged 2 commits into from
Aug 5, 2024
Merged

[Bugfix] Specify device when loading LoRA and embedding tensors #7129

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e78542f
fix: Specify device when loading LoRA and embedding tensors
Aug 4, 2024
274c3a2
Use device variable
Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vllm/lora/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ def from_local_checkpoint(
f" target modules in {expected_lora_modules}"
f" but received {unexpected_modules}."
f" Please verify that the loaded LoRA module is correct")
tensors = torch.load(lora_bin_file_path)
tensors = torch.load(lora_bin_file_path, map_location="device")
Copy link
Member

@youkaichao youkaichao Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test it? I don't think "device" works. this is a string.

else:
raise ValueError(f"{lora_dir} doesn't contain tensors")

Expand All @@ -257,7 +257,8 @@ def from_local_checkpoint(
embeddings = safetensors.torch.load_file(
new_embeddings_tensor_path)
elif os.path.isfile(new_embeddings_bin_file_path):
embeddings = torch.load(new_embeddings_bin_file_path)
embeddings = torch.load(new_embeddings_bin_file_path,
map_location="device")

rank = config["r"]
lora_alpha = config["lora_alpha"]
Expand Down