Skip to content

Conversation

@WoosukKwon
Copy link
Collaborator

For some environments like Runpod, users can't use docker and have to build vLLM from source. This PR adds the detailed instructions for it, which are extracted from Dockerfile.rocm.

cc @hongxiayang @mawong-amd

@WoosukKwon WoosukKwon requested a review from hongxiayang July 23, 2024 08:46
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@simon-mo
Copy link
Collaborator

@pandyamarut ^

@WoosukKwon
Copy link
Collaborator Author

@pandyamarut I wrote this script to test llama models on a 8xMI300x instance at Runpod. It worked with the ROCm 6.1 PyTorch image at Runpod.

@DarkLight1337 DarkLight1337 added the rocm Related to AMD ROCm label Jul 23, 2024
@pandyamarut
Copy link
Contributor

@simon-mo @WoosukKwon This looks good.

Copy link
Collaborator

@hongxiayang hongxiayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WoosukKwon ! Appreciate it.

@WoosukKwon WoosukKwon merged commit ccc4a73 into main Jul 24, 2024
@WoosukKwon WoosukKwon deleted the doc-mi300x branch July 24, 2024 08:07
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants